You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit abcd889
Browse filesBrowse the repository at this point in the historyBrowse files
authored
fix(replay): Fix Compose masking on obfuscated/minified builds (#5503)
* try to run replay tests on gh emulators
* Format code
* feat(replay): fail fast on swallowed Compose masking errors in CI
Add an internal SentryReplayDebug.failFast switch (gated on the
io.sentry.replay.compose.fail-fast system property) that re-throws the
exceptions ComposeViewHierarchyNode normally swallows in fromComposeNode
and fromView. Enabled in the sentry-samples-android app and the on-device
ReplayTest/ReplaySnapshotTest so our release/obfuscated builds running on
real devices in CI crash instead of silently degrading masking. Defaults
off, so customers are unaffected.
Also add consumer proguard keep rules for the LayoutNode internals
(getChildren/getOuterCoordinator/getCollapsedSemantics) that are looked up
via reflection on Compose < 1.10, so R8 doesn't strip or rename them.
Also guard the on-device tests against GitHub-hosted emulators, which
can't capture screenshots reliably.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copy file name to clipboardExpand all lines: sentry-android-integration-tests/sentry-uitest-android/src/androidTest/java/io/sentry/uitest/android/ReplayTest.kt
+3Lines changed: 3 additions & 0 deletions
Original file line number
Diff line number
Diff line change
@@ -21,6 +21,9 @@ class ReplayTest : BaseUiTest() {
21
21
// we can't run on GH actions emulator, because they don't allow capturing screenshots properly
Copy file name to clipboardExpand all lines: sentry-android-integration-tests/sentry-uitest-android/src/androidTestReplay/java/io/sentry/uitest/android/ReplaySnapshotTest.kt
+3Lines changed: 3 additions & 0 deletions
Original file line number
Diff line number
Diff line change
@@ -23,6 +23,9 @@ class ReplaySnapshotTest : BaseUiTest() {
23
23
// GH Actions emulators don't support capturing screenshots for replay
0 commit comments