Skip to content

Commit c5053ad

Browse files
authored
chore(android-sqlite): Remove experimental status from SentrySQLiteDriver (#5938)
Removes @ApiStatus.Experimental from SentrySQLiteDriver after reviewing production crash signal. Crash review (Sentry sdk-crashes-java + Datadog SDK Crash Detection): - Only a handful of events (~10 over ~2 weeks) mention SentrySQLiteDriver / SentrySQLiteStatement. All are ordinary Android SQLite failures (disk I/O, full disk, read-only, can’t open) that pass through the wrapper — not instrumentation bugs. - No ANRs, NPEs, or “Failed to instrument SQLite” failures on the io.sentry.sqlite path. - Datadog Android crash rates for versions with the driver (8.45+) look healthy (~0.5–1.6 SDK crashes per 1K crashes excl. ANRs); no post-release spike attributable to the driver. - Higher-volume “sqlite” noise in crash dashboards is almost entirely the older SentrySupportSQLite* path (same false-positive pattern: customer DB errors with our frames as culprit).
1 parent 4d15f0e commit c5053ad

3 files changed

Lines changed: 7 additions & 11 deletions

File tree

‎CHANGELOG.md‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@
66

77
- Make `ISpan.startChild` overloads with `SpanOptions` public ([#5927](https://github.com/getsentry/sentry-java/pull/5927))
88

9+
### Improvements
10+
11+
- Remove `ApiStatus.Experimental` annotation from `SentrySQLiteDriver` ([#5938](https://github.com/getsentry/sentry-java/pull/5938))
12+
913
### Fixes
1014

1115
- Clear contexts when calling `Scope.clear()` ([#5902](https://github.com/getsentry/sentry-java/pull/5902))

‎sentry-android-sqlite/build.gradle.kts‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -53,10 +53,6 @@ android {
5353

5454
buildFeatures { buildConfig = true }
5555

56-
// Needed b/c Kotlin 1.4.x would otherwise pull in an older version without the annotations we
57-
// want.
58-
configurations.all { resolutionStrategy.force(libs.jetbrains.annotations.get()) }
59-
6056
androidComponents.beforeVariants {
6157
it.enable = !Config.Android.shouldSkipDebugVariant(it.buildType)
6258
}
@@ -75,14 +71,12 @@ dependencies {
7571
api(projects.sentry)
7672

7773
compileOnly(libs.androidx.sqlite)
78-
compileOnly(libs.jetbrains.annotations)
7974

8075
implementation(kotlin(Config.kotlinStdLib, Config.kotlinStdLibVersionAndroid))
8176

8277
// tests
8378
testImplementation(libs.androidx.sqlite)
8479
testImplementation(libs.kotlin.test.junit)
85-
testImplementation(libs.androidx.test.ext.junit)
8680
testImplementation(libs.mockito.kotlin)
8781
testImplementation(libs.mockito.inline)
8882
}

‎sentry-android-sqlite/src/main/java/io/sentry/sqlite/SentrySQLiteDriver.kt‎

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,8 @@ package io.sentry.sqlite
33
import androidx.sqlite.SQLiteConnection
44
import androidx.sqlite.SQLiteDriver
55
import io.sentry.ScopesAdapter
6-
import io.sentry.SentryIntegrationPackageStorage
76
import io.sentry.SentryLevel
8-
import org.jetbrains.annotations.ApiStatus
7+
import io.sentry.util.IntegrationUtils.addIntegrationToSdkVersion
98

109
/**
1110
* Wraps a [SQLiteDriver] and automatically adds spans for each SQL statement it executes.
@@ -23,16 +22,15 @@ import org.jetbrains.annotations.ApiStatus
2322
* ```
2423
*
2524
* If you're using the Sentry Android Gradle Plugin (SAGP) 6.13.0+, wrapping will be performed
26-
* automatically.
25+
* automatically for Room.
2726
*
2827
* @param delegate The [SQLiteDriver] instance to delegate calls to.
2928
*/
30-
@ApiStatus.Experimental
3129
public class SentrySQLiteDriver private constructor(private val delegate: SQLiteDriver) :
3230
SQLiteDriver {
3331

3432
init {
35-
SentryIntegrationPackageStorage.getInstance().addIntegration("SQLiteDriver")
33+
addIntegrationToSdkVersion("SQLiteDriver")
3634
}
3735

3836
@Suppress("INAPPLICABLE_JVM_NAME")

0 commit comments

Comments
 (0)