Skip to content

Commit dcf7e17

Browse files
runningcodeclaude
andcommitted
ci(macrobenchmark): Call gradle directly instead of a Makefile target
Drop the assembleMacrobenchmark Makefile target and invoke the two gradle assemble tasks directly from the workflow. Only one workflow uses them, so the extra indirection isn't worth it. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1 parent 65c5ff0 commit dcf7e17

2 files changed

Lines changed: 3 additions & 8 deletions

File tree

‎.github/workflows/integration-tests-macrobenchmark.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,9 @@ jobs:
4242
with:
4343
cache-encryption-key: ${{ secrets.GRADLE_ENCRYPTION_KEY }}
4444

45-
- name: Make assembleMacrobenchmark
45+
- name: Assemble target app and Macrobenchmark apk
4646
if: env.SAUCE_USERNAME != null
47-
run: make assembleMacrobenchmark
47+
run: ./gradlew :sentry-samples:sentry-samples-android:assembleRelease :sentry-android-integration-tests:sentry-uitest-android-macrobenchmark:assembleBenchmark
4848

4949
- name: Run Macrobenchmark in SauceLab
5050
uses: saucelabs/saucectl-run-action@bc81720eb01738d9c664b07fe42621bd0014283f # pin@v3

‎Makefile‎

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
1-
.PHONY: all clean compile javadocs dryRelease update checkFormat api assembleBenchmarkTestRelease assembleMacrobenchmarkRelease assembleUiTestRelease assembleUiTestCriticalRelease runUiTestCritical setupPython systemTest systemTestInteractive check preMerge publish
1+
.PHONY: all clean compile javadocs dryRelease update checkFormat api assembleBenchmarkTestRelease assembleUiTestRelease assembleUiTestCriticalRelease runUiTestCritical setupPython systemTest systemTestInteractive check preMerge publish
22

33
all: stop clean javadocs compile
44
assembleBenchmarks: assembleBenchmarkTestRelease
5-
assembleMacrobenchmark: assembleMacrobenchmarkRelease
65
assembleUiTests: assembleUiTestRelease
76
preMerge: check
87
publish: clean dryRelease
@@ -40,10 +39,6 @@ api:
4039
assembleBenchmarkTestRelease:
4140
./gradlew :sentry-android-integration-tests:sentry-uitest-android-benchmark:assembleRelease :sentry-android-integration-tests:sentry-uitest-android-benchmark:assembleAndroidTest
4241

43-
# Assemble the target sample app (release) and the Macrobenchmark instrumentation apk
44-
assembleMacrobenchmarkRelease:
45-
./gradlew :sentry-samples:sentry-samples-android:assembleRelease :sentry-android-integration-tests:sentry-uitest-android-macrobenchmark:assembleBenchmark
46-
4742
# Assemble release and Android test apk of the uitest-android module
4843
assembleUiTestRelease:
4944
./gradlew :sentry-android-integration-tests:sentry-uitest-android:assembleRelease :sentry-android-integration-tests:sentry-uitest-android:assembleAndroidTest

0 commit comments

Comments
 (0)