ref(android): Store metadata in manifest reader

Use ManifestMetadataReader directly as the Gradle plugin injection target and remove the dedicated holder class.

Co-Authored-By: OpenAI Codex <noreply@openai.com>

Author: romtsn

sentry-android-core/src/main/java/io/sentry/android/core/ManifestMetadataReader.java

@@ -26,9 +26,8 @@
 /** Class responsible for reading values from manifest and setting them to the options */
 final class ManifestMetadataReader {
 
-  // Populated by the Sentry Android Gradle plugin with manifest metadata resolved at build time.
-  // When set, it is authoritative: the manifest is not read at runtime.
-  static @Nullable Map<String, Object> buildTimeMetadata;
+  // Populated by the Sentry Android Gradle plugin from the merged manifest at build time.
+  static @Nullable Map<String, Object> manifestMetadata;
 
   static final String DSN = "io.sentry.dsn";
   static final String DEBUG = "io.sentry.debug";
@@ -930,7 +929,7 @@ static boolean isAutoInit(final @NotNull Context context, final @NotNull ILogger
       final @NotNull Context context,
       final @NotNull ILogger logger,
       final @Nullable BuildInfoProvider buildInfoProvider) {
-    final @Nullable Map<String, Object> injected = buildTimeMetadata;
+    final @Nullable Map<String, Object> injected = manifestMetadata;
     if (injected != null) {
       return injected;
     }

sentry-android-core/src/test/java/io/sentry/android/core/ManifestMetadataReaderTest.kt

@@ -47,13 +47,13 @@ class ManifestMetadataReaderTest {
 
   @AfterTest
   fun `tear down`() {
-    ManifestMetadataReader.buildTimeMetadata = null
+    ManifestMetadataReader.manifestMetadata = null
   }
 
   @Test
   fun `applyMetadata reads typed build-time metadata without querying context`() {
     val context = mock<Context>()
-    ManifestMetadataReader.buildTimeMetadata =
+    ManifestMetadataReader.manifestMetadata =
       mapOf(
         ManifestMetadataReader.DEBUG to true,
         ManifestMetadataReader.DIST to "dist",
@@ -74,7 +74,7 @@ class ManifestMetadataReaderTest {
   fun `build-time metadata is authoritative when a key is absent`() {
     val context = mock<Context>()
     fixture.options.dist = "configured"
-    ManifestMetadataReader.buildTimeMetadata = emptyMap()
+    ManifestMetadataReader.manifestMetadata = emptyMap()
 
     ManifestMetadataReader.applyMetadata(context, fixture.options, fixture.buildInfoProvider)
 
@@ -85,7 +85,7 @@ class ManifestMetadataReaderTest {
   @Test
   fun `isAutoInit reads build-time metadata without querying context`() {
     val context = mock<Context>()
-    ManifestMetadataReader.buildTimeMetadata = mapOf(ManifestMetadataReader.AUTO_INIT to false)
+    ManifestMetadataReader.manifestMetadata = mapOf(ManifestMetadataReader.AUTO_INIT to false)
 
     assertThat(ManifestMetadataReader.isAutoInit(context, fixture.logger)).isFalse()
     verifyNoInteractions(context)