fix(core): Resolve the remaining Error Prone and javac 21 findings in the sentry module

Author: markushi

sentry/src/main/java/io/sentry/CombinedContextsView.java

@@ -243,7 +243,7 @@ public void setSpring(@NotNull Spring spring) {
 
   @ApiStatus.Internal
   @Override
-  /** Not intended to be set on a scopes Context directly */
+  /* Not intended to be set on a scopes Context directly */
   public void setFeatureFlags(@NotNull FeatureFlags spring) {
     getDefaultContexts().setFeatureFlags(spring);
   }

sentry/src/main/java/io/sentry/DateUtils.java

@@ -151,10 +151,10 @@ public static double nanosToSeconds(final long nanos) {
    */
   @SuppressWarnings("JavaUtilDate")
   public static double dateToSeconds(final @NotNull Date date) {
-    return millisToSeconds(date.getTime());
+    return millisToSeconds((double) date.getTime());
   }
 
-  public static long secondsToNanos(final @NotNull long seconds) {
+  public static long secondsToNanos(final long seconds) {
     return seconds * (1000L * 1000L * 1000L);
   }
 

sentry/src/main/java/io/sentry/DefaultSpanFactory.java

@@ -21,7 +21,7 @@ public final class DefaultSpanFactory implements ISpanFactory {
       final @NotNull SpanOptions spanOptions,
       final @NotNull SpanContext spanContext,
       @Nullable ISpan parentSpan) {
-    /**
+    /*
      * Be careful here when executing something like parentSpan.startChild() as that might cause a
      * loop and a stack overflow. This can happen, e.g. when OpenTelemetry is creating spans that
      * use OtelSpanWrapper which calls this createSpan method that then in turn calls startChild

sentry/src/main/java/io/sentry/DirectoryProcessor.java

@@ -120,7 +120,7 @@ private static final class SendCachedEnvelopeHint
     private final @NotNull String filePath;
     private final @NotNull Queue<String> processedEnvelopes;
 
-    public SendCachedEnvelopeHint(
+    SendCachedEnvelopeHint(
         final long flushTimeoutMillis,
         final @NotNull ILogger logger,
         final @NotNull String filePath,

sentry/src/main/java/io/sentry/ExternalOptions.java

@@ -242,7 +242,8 @@ public final class ExternalOptions {
 
     String profileLifecycleString = propertiesProvider.getProperty("profile-lifecycle");
     if (profileLifecycleString != null && !profileLifecycleString.isEmpty()) {
-      options.setProfileLifecycle(ProfileLifecycle.valueOf(profileLifecycleString.toUpperCase()));
+      options.setProfileLifecycle(
+          ProfileLifecycle.valueOf(profileLifecycleString.toUpperCase(Locale.ROOT)));
     }
 
     return options;

sentry/src/main/java/io/sentry/Hint.java

@@ -60,7 +60,7 @@ public void set(@NotNull String name, @Nullable Object hint) {
   }
 
   @SuppressWarnings("unchecked")
-  public <T extends Object> @Nullable T getAs(@NotNull String name, @NotNull Class<T> clazz) {
+  public <T> @Nullable T getAs(@NotNull String name, @NotNull Class<T> clazz) {
     try (final @NotNull ISentryLifecycleToken ignored = lock.acquire()) {
       Object hintValue = internalStorage.get(name);
 

sentry/src/main/java/io/sentry/SamplingContext.java

@@ -20,7 +20,7 @@ public final class SamplingContext {
 
   @Deprecated
   @SuppressWarnings("InlineMeSuggester")
-  /**
+  /*
    * @deprecated creating a SamplingContext is something only the SDK should do
    */
   public SamplingContext(

sentry/src/main/java/io/sentry/Scope.java

@@ -463,10 +463,10 @@ public Queue<Breadcrumb> getBreadcrumbs() {
    */
   private @Nullable Breadcrumb executeBeforeBreadcrumb(
       final @NotNull SentryOptions.BeforeBreadcrumbCallback callback,
-      @NotNull Breadcrumb breadcrumb,
+      final @NotNull Breadcrumb breadcrumb,
       final @NotNull Hint hint) {
     try (final @NotNull ISentryLifecycleToken ignored = SentryCallbackReentrancyGuard.enter()) {
-      breadcrumb = callback.execute(breadcrumb, hint);
+      return callback.execute(breadcrumb, hint);
     } catch (Throwable e) {
       options
           .getLogger()
@@ -476,7 +476,6 @@ public Queue<Breadcrumb> getBreadcrumbs() {
               e);
       return null;
     }
-    return breadcrumb;
   }
 
   /**

sentry/src/main/java/io/sentry/SentryEnvelopeItem.java

@@ -691,11 +691,12 @@ private static class CachedItem {
     private @Nullable byte[] bytes;
     private final @Nullable Callable<byte[]> dataFactory;
 
-    public CachedItem(final @Nullable Callable<byte[]> dataFactory) {
+    CachedItem(final @Nullable Callable<byte[]> dataFactory) {
       this.dataFactory = dataFactory;
     }
 
-    public @NotNull byte[] getBytes() throws Exception {
+    @NotNull
+    byte[] getBytes() throws Exception {
       if (bytes == null && dataFactory != null) {
         bytes = dataFactory.call();
       }

sentry/src/main/java/io/sentry/SentryExceptionFactory.java

@@ -11,6 +11,7 @@
 import java.util.Deque;
 import java.util.HashSet;
 import java.util.List;
+import java.util.Set;
 import java.util.concurrent.atomic.AtomicInteger;
 import org.jetbrains.annotations.ApiStatus;
 import org.jetbrains.annotations.NotNull;
@@ -141,7 +142,7 @@ Deque<SentryException> extractExceptionQueue(final @NotNull Throwable throwable)
   Deque<SentryException> extractExceptionQueueInternal(
       final @NotNull Throwable throwable,
       final @NotNull AtomicInteger exceptionId,
-      final @NotNull HashSet<Throwable> circularityDetector,
+      final @NotNull Set<Throwable> circularityDetector,
       final @NotNull Deque<SentryException> exceptions,
       @Nullable String mechanismTypeOverride) {
     Mechanism exceptionMechanism;