Skip to content

docs: Allow broad catches only at SDK boundaries - #6187

Merged
runningcode merged 2 commits into
mainfrom
no/exception-handling-boundaries
Nov 6, 2026
Merged

runningcode merged 2 commits into
mainfrom
no/exception-handling-boundaries

Conversation

@runningcode

@runningcode runningcode commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

📜 Description

Rewrite AGENTS.md and bugbot.md to make our error handling policy more clear. Feel free to debate anything here. I just wrote what I think would make sense but we should agree on all of these as a team.

💡 Motivation and Context

As discussed on our android-sdk meeting.

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.
  • Public API changes reviewed by another Mobile SDK team member or implemented according to the develop docs spec.

#skip-changelog

🤖 Generated with Claude Code

@linear-code

linear-code Bot commented Sep 29, 2026

Copy link
Copy Markdown

JAVA-748

@sentry

sentry Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
SDK Size io.sentry.tests.size 8.63.0 (1) release

⚙️ sentry-android Build Distribution Settings

Comment thread AGENTS.md Resolved
@runningcode
runningcode marked this pull request as ready for review September 29, 2026 12:27
@runningcode runningcode added the deep-dive PR needs a thorough review of design, behavior, and edge cases label Sep 30, 2026
Comment thread AGENTS.md Resolved
Comment thread AGENTS.md Resolved

@0xadam-brown 0xadam-brown left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice – thanks for the updates 💯

Comment thread .cursor/BUGBOT.md Resolved
runningcode and others added 2 commits November 6, 2026 14:04
Inside the SDK, catch the narrowest type. Broad catches are allowed only
at boundaries where the thrown types are unknowable, must call
rethrowIfFatal first, and must document what happens on failure. Align
BUGBOT.md with AGENTS.md so Bugbot enforces the same policy.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@runningcode
runningcode force-pushed the no/exception-handling-boundaries branch from 8f4bf15 to 1581f85 Compare November 6, 2026 13:16
@runningcode
runningcode requested a review from a team as a code owner November 6, 2026 13:16
@runningcode
runningcode enabled auto-merge (squash) November 6, 2026 14:07
@runningcode
runningcode merged commit 0135df8 into main Nov 6, 2026
44 checks passed
@runningcode
runningcode deleted the no/exception-handling-boundaries branch November 6, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deep-dive PR needs a thorough review of design, behavior, and edge cases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants