Repository navigation
feat(spring): Add an option to monitor all @Scheduled methods in Spring Boot 4 - #6277
Merged
Merged
Conversation
…figs Framework-free conversion of a 6 field cron expression, fixed rate or fixed delay into a MonitorConfig, plus period parsing, so the Spring and Quartz integrations can share it.
Return no config when day of month and day of week are both set, for cron syntax Sentry rejects, and for zones that are not IANA region IDs. Whole-hour fixed offsets map to Etc/GMT zones. Intervals use hours or days when they divide evenly.
Move the Spring day-of-week rewrite and the JVM default zone rule into core so the three Spring modules share them.
Spring and Quartz run 10-10/2 only at 10, cronsim steps to the field max.
Spring before 5.3 steps day of month */n from 0 and can run at midnight when both day fields are set; read its crons that way. Spring 5.3 runs #5 in months without a fifth weekday, so return null for it. A fixed delay drifts from any interval, so it gets no config.
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
SUN-SUN was rewritten to 0-7, which crontab reads as every day. Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
…tor-scheduled-tasks Adds sentry.monitor-scheduled-tasks and sentry.exclude-scheduled-tasks to Spring Boot 3. Methods without @SentryCheckIn get a slug from the class and method name and send their @scheduled schedule as the monitor config. Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
1 of 3 tasks
Contributor
|
📲 Install BuildsAndroid
|
wedamija
changed the title
… all tasks Spring calls reactive and suspend @scheduled methods once at startup and subscribes to the result on each run, so check-ins around the call would only be sent once. Co-Authored-By: Claude <noreply@anthropic.com>
…onitor-scheduled-tasks-boot2
Same fix as the Spring Boot 3 copy. Co-Authored-By: Claude <noreply@anthropic.com>
…ring-monitor-scheduled-tasks-boot4
…asks Same fix as the Spring Boot 3 copy. Co-Authored-By: Claude <noreply@anthropic.com>
…sks' into danf-skip-tmp-6276
…monitor-scheduled-tasks # Conflicts: # CHANGELOG.md
An overriding method without @scheduled isn't scheduled by Spring, so don't monitor it either.
…onitor-scheduled-tasks-boot2 # Conflicts: # CHANGELOG.md
An overriding method without @scheduled isn't scheduled by Spring, so don't monitor it either.
…ring-monitor-scheduled-tasks-boot4 # Conflicts: # CHANGELOG.md
An overriding method without @scheduled isn't scheduled by Spring, so don't monitor it either.
wedamija
marked this pull request as ready for review
November 5, 2026 19:45
wedamija
requested review from
romtsn and
runningcode
and removed request for
a team
November 5, 2026 19:45
…cheduled-tasks # Conflicts: # CHANGELOG.md # sentry-spring-jakarta/src/main/java/io/sentry/spring/jakarta/checkin/SentryCheckInAdvice.java
Derived slugs use only the short class name and method name, so different methods can map to the same slug and share one monitor. Log a warning the first time that happens so users can set an explicit slug.
…onitor-scheduled-tasks-boot2 # Conflicts: # CHANGELOG.md
Derived slugs use only the short class name and method name, so different methods can map to the same slug and share one monitor. Log a warning the first time that happens so users can set an explicit slug.
…ring-monitor-scheduled-tasks-boot4 # Conflicts: # CHANGELOG.md
Derived slugs use only the short class name and method name, so different methods can map to the same slug and share one monitor. Log a warning the first time that happens so users can set an explicit slug.
Use the same class for the task name and the collision check so both see one value.
…onitor-scheduled-tasks-boot2
Use the same class for the task name and the collision check so both see one value.
…ring-monitor-scheduled-tasks-boot4
…ng all tasks Spring invokes private and static scheduled methods on the target, so the proxy never sees them. Don't match them, so they aren't proxied for nothing.
…onitor-scheduled-tasks-boot2
…ng all tasks Spring invokes private and static scheduled methods on the target, so the proxy never sees them. Don't match them, so they aren't proxied for nothing.
…ring-monitor-scheduled-tasks-boot4
…ng all tasks Spring invokes private and static scheduled methods on the target, so the proxy never sees them. Don't match them, so they aren't proxied for nothing.
Base automatically changed from
danf/spring-monitor-scheduled-tasks-boot2
to
main
November 5, 2026 22:13
…boot4 # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of a series adding automatic Crons monitoring for the most-used job schedulers in each SDK. Check-ins for a monitor that doesn't exist yet are dropped, so today each monitor has to be created by hand with its schedule copied from the code. Sending the job's schedule as the monitor config lets Sentry create the monitor and keep it in sync.
Same change as #6275 for Spring Boot 4 (
sentry-spring-7andsentry-spring-boot-4):sentry.monitor-scheduled-tasksandsentry.exclude-scheduled-tasks, with the same code and tests.Stacked on #6276.