Repository navigation
build: Replace deprecated AGP BaseExtension in JdkTargetConvention - #6406
Merged
Merged
Conversation
BaseExtension is deprecated in AGP 9 and removed in AGP 10, and it is not the registered android extension once android.newDsl=true. The DSL LibraryExtension exposes the same compileOptions and aarMetadata blocks and works with both DSL modes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
📲 Install BuildsAndroid
|
romtsn
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
JdkTargetConventionnow looks up the Android library extension ascom.android.build.api.dsl.LibraryExtensioninstead of the deprecatedcom.android.build.gradle.BaseExtension. ThecompileOptionsandaarMetadataconfiguration is unchanged.💡 Motivation and Context
Compiling build-logic printed two deprecation warnings:
The DSL
LibraryExtensionworks withandroid.newDsl=false, which we set today, and keeps working once we flip it.💚 How did you test it?
:build-logic:compileKotlinno longer prints the warnings, andsentry-android-core's generatedaar-metadata.propertiesstill hasminCompileSdk=21.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
🤖 Generated with Claude Code
#skip-changelog