Repository navigation
ref(android): [Part 1] Refactor - #6481
Open
0xadam-brown wants to merge 1 commit into
Open
0xadam-brown wants to merge 1 commit into
0xadam-brown wants to merge 1 commit into
Conversation
… the README Prepares the Nav3 lifecycle stack without changing behavior. SentryNavEffect now attaches a NavRootInfo (the nav root's lifecycle plus the Activity that displays it), which later lease withdrawal needs. Renames LeasedNavState to INavStatePublisher, publisher to lastPublisher, and hasAppliedInitialBackStackUpdate to hasHandledFirstUpdate/canReceiveLease, and says "nav root" rather than "owner" throughout. The lease policy (tradeoff, handoff, diagram) moves from the NavLeaseCoordinator KDoc to the package README, so later changes to the policy are reviewed as prose.
5 of 9 tasks
📲 Install BuildsAndroid
|
This was referenced Nov 6, 2026
0xadam-brown
changed the title
0xadam-brown
changed the title
0xadam-brown
marked this pull request as ready for review
November 6, 2026 12:31
0xadam-brown
requested review from
romtsn and
runningcode
and removed request for
a team
November 6, 2026 12:31
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (Nav3 Lifecycle)
📜 Description
Groundwork for the rest of this PR stack. No behavior changes.
[1] Introduces
NavRootInfo: Gives us a place to define "nav root", and will let us encapsulate multiple pieces of info from the nav root in future PRs in this stack.[2] Renames some types, members, etc. for clarity and consistency: LeasedNavState → INavStatePublisher, hasAppliedInitialBackStackUpdate → hasHandledFirstUpdate / canReceiveLease, etc.
[3] Adds a
compileOnlydep onandroidx.compose.ui: Used to provideLocalContext, which will be needed in subsequent PRs.[4] Doc improvements, etc.
💡 Motivation and Context
Confines trivial updates to a single PR and keeps later PRs cleaner.
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
The next PR in the stack starts a new nav transaction when the user returns to a Nav3 root.
#skip-changelog