Repository navigation
fix(sample): Apply Nav3 sample options when a child Activity is restored - #6485
Open
0xadam-brown wants to merge 1 commit into
Open
0xadam-brown wants to merge 1 commit into
0xadam-brown wants to merge 1 commit into
Conversation
Only Nav3Activity applied the sample's settings (screen tracking, user-interaction transactions and breadcrumbs) to the SDK options. When Android restored the process straight into Nav3ProductsActivity, Nav3CheckoutActivity, or Nav3FragmentsActivity, the options stayed at the app's init defaults, which have user-interaction tracing on. Each of those Activities now applies the configuration from its intent extras in onCreate.
📲 Install BuildsAndroid
|
0xadam-brown
marked this pull request as ready for review
November 6, 2026 09:55
0xadam-brown
requested review from
romtsn and
runningcode
and removed request for
a team
November 6, 2026 09:55
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Nav3ProductsActivity,Nav3CheckoutActivity(which also coversNav3TranslucentCheckoutActivity), andNav3FragmentsActivitynow apply the sample's configuration to the live SDK options inonCreate.💡 Motivation and Context
Only
Nav3Activityapplied the sample's settings (screen tracking, user-interaction transactions and breadcrumbs) to the SDK options. The child Activities read the same configuration from their intent extras but never applied it. When Android restores the process straight into a child Activity,Nav3Activityisn't recreated, so the options stayed at the app's init defaults. Those defaults have user-interaction tracing on, so taps createdui.action.clicktransactions even with the toggle off.Sample only. Split out of the Nav3 Lifecycle stack (#6480).
💚 How did you test it?
On an API 28 emulator, I turned user-interaction tracing off, opened
Nav3ProductsActivity, killed the process witham kill, and restored the task. With this change, a tap made noui.action.clicktransaction. Without it, it made one. That test ran on the original Nav3 Lifecycle branch, from which this change is copied unchanged. The sample compiles on top ofmain.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
None.
#skip-changelog