Skip to content

test(spring-boot): Keep the Log4j2 LoggerContext reachable in appender auto-configuration tests #6488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markushi merged 1 commit into from
Nov 6, 2026
Merged

test(spring-boot): Keep the Log4j2 LoggerContext reachable in appender auto-configuration tests #6488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ...oot-4/src/test/kotlin/io/sentry/spring/boot4/SentryLog4j2AppenderAutoConfigurationTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,9 @@ class SentryLog4j2AppenderAutoConfigurationTest {

private val originalLogManagerFactory = LogManager.getFactory()

private val loggerContext: LoggerContext
get() = LogManager.getContext(false) as LoggerContext
// Log4j2 holds LoggerContexts weakly, so a GC during context startup would replace this one
// (and drop appenders added by a test) unless the test keeps it reachable.
private lateinit var loggerContext: LoggerContext

private val configuration
get() = loggerContext.configuration
Expand All @@ -85,6 +86,7 @@ class SentryLog4j2AppenderAutoConfigurationTest {
fun `reset Log4j2 context`() {
useLog4j2Core()
resetLog4j2Context()
loggerContext = LogManager.getContext(false) as LoggerContext
}

@AfterTest
Expand Down
6 changes: 4 additions & 2 deletions ...rc/test/kotlin/io/sentry/spring/boot/jakarta/SentryLog4j2AppenderAutoConfigurationTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,9 @@ class SentryLog4j2AppenderAutoConfigurationTest {

private val originalLogManagerFactory = LogManager.getFactory()

private val loggerContext: LoggerContext
get() = LogManager.getContext(false) as LoggerContext
// Log4j2 holds LoggerContexts weakly, so a GC during context startup would replace this one
// (and drop appenders added by a test) unless the test keeps it reachable.
private lateinit var loggerContext: LoggerContext

private val configuration
get() = loggerContext.configuration
Expand All @@ -85,6 +86,7 @@ class SentryLog4j2AppenderAutoConfigurationTest {
fun `reset Log4j2 context`() {
useLog4j2Core()
resetLog4j2Context()
loggerContext = LogManager.getContext(false) as LoggerContext
}

@AfterTest
Expand Down
Loading