Repository navigation
build(uitest): Disable lint's Gradle version check - #6515
Merged
Merged
Conversation
Lint checks the build root's gradle-wrapper.properties in a single module it picks per build. Since the integration tests moved into their own build, that module is sentry-uitest-android, which treats warnings as errors. AndroidGradlePluginVersion compares the wrapper with the latest Gradle release online, so the Gradle 9.9.0 release turned the Samples workflow red on main without any change on our side. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
runningcode
marked this pull request as ready for review
November 9, 2026 09:26
runningcode
requested review from
markushi and
romtsn
and removed request for
a team
November 9, 2026 09:26
📲 Install BuildsAndroid
|
0xadam-brown
approved these changes
Nov 9, 2026
0xadam-brown
left a comment
0xadam-brown
left a comment
Member
There was a problem hiding this comment.
Looks like the other Android modules keep this check, so it's just for our integration tests that we disable it (where we're deliberate about pinning an AGP version, anyway) 👍
markushi
approved these changes
Nov 9, 2026
Contributor
Author
No, its not at all about AGP, its about a Gradle version. So its entirely misnamed. The reason we're keeping it for the other modules is just that it doesn't affect them due to the weird behavior of how this lint check works. See the PR description which explains why this never happened before as well as why it isn't happening in the other modules. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
mainis broken because Gradle 9.9.0 was released and now this lint check is failing.Weird that we didn't have this issue before but splitting apart the build revealed some interesting errors.
Here's what my clanker found as to why this wasn't happening before.
Lint checks the build root's
gradle.propertiesandgradle-wrapper.propertiesin a single module per build: the firstinclude(":…")in settings, or, since our includes have no leading colon, the alphabetically first folder with a build file. Since the integration tests moved into their own build, that'ssentry-uitest-android, which setswarningsAsErrors. The check compares the wrapper with the latest Gradle release online, so every Gradle release would break the build again. The other builds don't hit this because lint's pick there (build-logic,macrobenchmark) never runs this check.💚 How did you test it?
./gradlew -p sentry-android-integration-tests lintReleasefails onmainand passes with this change.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
#skip-changelog
🤖 Generated with Claude Code