Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
📲 Install BuildsAndroid
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Adds
SentryWebViewTracing.addTracePropagation(webView). When no hosts are passed, the allowed hosts come fromtracePropagationTargets.Only entries that name a plain host are used, because
tracePropagationTargetsare substring or regex matches on a full URL, and the WebView needs origin rules:api.example.comhttps://api.example.com/https://*.example.com.*(the default), a regex, an entry with a path, a host with no dot such ascomfalsePassing hosts explicitly works as before and takes priority.
💡 Motivation and Context
Reusing the existing option avoids a second host list, and could give automatic instrumentation through the Gradle plugin (#6407) an app-wide list.
Open questions:
tracePropagationTargetsacceptable as this trust boundary? The list is usually written with backends in mind, but here every script on a matching page can read the trace. This needs Security's review.co.ukstill passes the filter; catching it needs a public-suffix list.allowedHosts, so this would differ from it.💚 How did you test it?
Unit tests for the target filter, the origin rules, and the new overload, including the default
.*.:sentry-android-core:check,spotlessCheck, andcheckKotlinAbipass. Not run on a device yet.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
If we go ahead: Security review, docs (getsentry/sentry-docs#20550), and a test on a device.
🤖 Generated with Claude Code