Repository navigation
Conversation
Avoid inlining Ktor 3.6's AttributeKey factory. The inlined code references a TypeInfo constructor unavailable in older Ktor 3.x runtimes. Construct TypeInfo explicitly through its stable two-argument constructor instead.
adinauer
marked this pull request as ready for review
November 9, 2026 13:18
adinauer
requested review from
markushi and
runningcode
and removed request for
a team
November 9, 2026 13:18
📲 Install BuildsAndroid
|
6 of 9 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (Ktor 3.6)
📜 Description
Construct the Ktor client plugin's attribute keys with explicit
TypeInfovalues instead of using Ktor's inlineAttributeKeyfactory.💡 Motivation and Context
When compiled against Ktor 3.6.1, the inline factory embeds a call to a new three-argument
TypeInfoconstructor. Running those compiled SDK classes with older Ktor 3.x versions then fails withNoSuchMethodError.The explicit construction uses the stable two-argument
TypeInfoconstructor and preserves runtime compatibility with Ktor 3.0.0 through 3.6.1.💚 How did you test it?
./gradlew spotlessApply updateKotlinAbiSentryKtorClientPluginTesttests after compiling once against Ktor 3.6.1 and replacing only the Ktor runtime dependencies with 3.0.0, 3.1.3, 3.2.3, 3.3.3, 3.4.3, 3.5.1, and 3.6.1; all passed./gradlew :sentry-ktor-client:checkKotlinAbijavapthat the compiled plugin callsTypeInfo(KClass, KType)and does not referenceTypeInfo(KClass, boolean, KType)📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
None.
#skip-changelog