Repository navigation
ref(android): Remove code made obsolete by minSdk 24 - #6519
Open
runningcode wants to merge 2 commits into
Open
runningcode wants to merge 2 commits into
runningcode wants to merge 2 commits into
Conversation
Remove the SDK_INT checks for API 24 and lower, with the branches they guarded, and turn lint's ObsoleteSdkInt check back on. Most checks go through BuildInfoProvider, which lint doesn't see, so it flagged only five of them. Code for API 25 and lower, such as the bundled root CAs, the pre-O screenshot canvas and the Choreographer frame start, stays. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
3 of 9 tasks
📲 Install BuildsAndroid
|
runningcode
marked this pull request as ready for review
November 9, 2026 13:47
runningcode
requested review from
0xadam-brown and
romtsn
and removed request for
a team
November 9, 2026 13:47
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (minSdk 24)
📜 Description
This is just my agent going through the codebase systematically to remove dead code.
Here's an AI summary of what this does:
Removes the code that minSdk 24 (#6518) made dead, and turns the
ObsoleteSdkIntlint check back on.AndroidTransactionProfilerandAndroidContinuousProfilerAndroidConnectionStatusProvider,NetworkBreadcrumbsIntegrationandCellularNetworkTechnologyProvider, including the deprecatedNetworkInfotransport fallbackProcess.getStartUptimeMillis()inSentryAndroidandSentryPerformanceProvider, and the pre-M fallback forMessageQueue.addIdleHandlerinAppStartMetricsSentryFrameMetricsCollector: the API 24 availability check@RequiresApi/@TargetApiannotations for API 24 and lower insentry-android-coreandsentry-android-replay💡 Motivation and Context
Follow-up to #6518.
💚 How did you test it?
CI
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
After #6518 is squash-merged, this branch needs
9.x.xmerged in before it can be merged.🤖 Generated with Claude Code
#skip-changelog