Repository navigation
Conversation
8 of 9 tasks
📲 Install BuildsAndroid
|
7 of 9 tasks
…#6475) Bumps [javax.servlet:javax.servlet-api](https://github.com/javaee/servlet-spec) from 3.1.0 to 4.0.1. - [Commits](javaee/servlet-spec@3.1.0...4.0.1) --- updated-dependencies: - dependency-name: javax.servlet:javax.servlet-api dependency-version: 4.0.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Compile the javax servlet integrations against the minimum supported API. Exclude the intentionally pinned API from Dependabot while retaining the separate Servlet 4 alias for latest-runtime coverage. Co-Authored-By: Claude <noreply@anthropic.com>
adinauer
marked this pull request as ready for review
November 17, 2026 13:23
adinauer
requested review from
0xadam-brown and
markushi
and removed request for
a team
November 17, 2026 13:23
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (Servlet API)
📜 Description
Keep
javax.servlet:javax.servlet-apiat 3.1.0 as the production compile target and exclude the intentionally pinned dependency from Dependabot updates.Add a real-container integration test that runs on both Tomcat 8.5 / Servlet 3.1 and Tomcat 9 / Servlet 4.0.
💡 Motivation and Context
Compiling against the minimum supported Servlet API prevents accidental use of Servlet 4-only APIs. The runtime matrix verifies that the same standalone
sentry-servletintegration works at both ends of the supportedjavax.servletrange.The existing
servlet4-apicatalog alias remains available for code that intentionally targets Servlet 4.💚 How did you test it?
make format api./gradlew :sentry-servlet:integrationTest :sentry-servlet:integrationTestTomcat9 --rerun-tasks --no-build-cachecompileClasspathresolvesjavax.servlet-api:3.1.0📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Merge PR #6625 into this branch with a merge commit, then squash-merge this collection PR into
main.#skip-changelog