Repository navigation
fix(replay): Support Compose 1.13 and mask Compose views that can't be traversed - #6626
Merged
Merged
Conversation
markushi
requested review from
0xadam-brown and
runningcode
and removed request for
a team
November 16, 2026 19:22
📲 Install BuildsAndroid
|
runningcode
reviewed
Nov 17, 2026
runningcode
reviewed
Nov 17, 2026
…e unit test tasks
3 tasks done
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
LayoutNodechildren and transparency through the unmangledSemanticsInfoAPI (childrenInfo,isTransparent()), because Compose 1.13 renamed the mangled internals. Compose < 1.8 keeps the reflection fallback.Why
childrenInfoandisTransparent()are drop-in replacementsBoth are public, unmangled
SemanticsInfomembers onLayoutNode(afinalclass). Each one only forwards to the mangled internal that we called before:Only
<suffix>changes between versions. I disassembled all 57androidx.compose.ui:ui-androidreleases from 1.9.0-alpha01 to 1.13.0-rc01:getChildrenInfo()callsisTransparent()callsgetChildren$ui_release()getOuterCoordinator$ui_release()getChildren$ui()getOuterCoordinator$ui()getChildren$androidx_compose_ui_ui()getOuterCoordinator$androidx_compose_ui_ui()The SDK compiles against 1.10.2, so the old direct calls were fixed to
$uiand threwNoSuchMethodErrorfrom 1.13.0-beta01. The reflection fallback only knows the$ui_releasenames.💚 How did you test it?
Unit tests in
ComposeMaskingOptionsTest, and the new Compose matrix workflow.Manual testing: https://sentry-sdks.sentry.io/explore/replays/9a84e9904b76410bb06bddc5cf2ab36a
📝 Checklist
🤖 Generated with Claude Code