Repository navigation
build(otel): Register agent without-auto-init tests as a suite target - #6632
Merged
Merged
Conversation
The without-auto-init run uses the same classes and classpath as the integrationTestOtelAgent suite and differs only in one JVM argument. Registering it as a second target of the suite lets Gradle set up its test classes, classpath and test framework, instead of copying them into a hand-made Test task. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
📲 Install BuildsAndroid
|
runningcode
marked this pull request as ready for review
November 17, 2026 09:16
runningcode
requested review from
0xadam-brown and
romtsn
and removed request for
a team
November 17, 2026 09:16
0xadam-brown
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
OtelAgentTestsPluginnow registersintegrationTestOtelAgentWithoutAutoInitas a second target of theintegrationTestOtelAgentJVM test suite, instead of as a hand-madeTesttask.💡 Motivation and Context
The without-auto-init run uses the suite's classes and classpath and differs only in one JVM argument. A suite target gets its test classes, classpath, test framework and verification group from the suite, so the plugin no longer copies them by hand. Task names stay the same, and so do the Spring Boot matrix tasks.
💚 How did you test it?
./gradlew :sentry-spring-boot:integrationTestOtelAgent :sentry-spring-boot:integrationTestOtelAgentWithoutAutoInitpasses, with the same 22 tests in eachChildJvmTestArgumentsprovider and its ownsentry.test.agentAutoInitvalue (trueandfalse)📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
None.
#skip-changelog
🤖 Generated with Claude Code