Skip to content

build(deps): Bump androidx.lifecycle to 2.10.0 in Nav3 and uitests - #6664

Merged
runningcode merged 2 commits into
9.x.xfrom
no/java-832-lifecycle-2-10
Nov 19, 2026
Merged

runningcode merged 2 commits into
9.x.xfrom
no/java-832-lifecycle-2-10

Conversation

@runningcode

@runningcode runningcode commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

📜 Description

Problem, AGP's lint can't load the lint checks in androidx.lifecycle 2.8.3 so we had to enable supressing ObsoleteLintCustomCheck.
We previously couldn't bump this becuase it requires a minSdk of 24 so we couldn't do anything. Now that we have minSdk 24 on 9.x.x, we can bump and remove the obsolete custom lint check.

💡 Motivation and Context

Fixes #6541
Linear: JAVA-832

Lifecycle 2.10.0 needs minSdk 23, so only 9.x.x, which is on minSdk 24, can take it.

💚 How did you test it?

With the check re-enabled, lint is clean for sentry-android-navigation3 in the root build and for sentry-uitest-android in the sentry-android-integration-tests build. The navigation3 unit tests pass.

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.
  • Public API changes reviewed by another Mobile SDK team member or implemented according to the develop docs spec.

🔮 Next steps

The other four modules can drop the suppression once v9 raises their minimum supported AndroidX versions to ones that pull lifecycle 2.10.0 or newer.

🤖 Generated with Claude Code

runningcode and others added 2 commits November 18, 2026 16:37
Lint 9.5 can't load the custom lint checks of lifecycle releases before 2.10.0, so #6540
disabled ObsoleteLintCustomCheck. 9.x.x is on minSdk 24, so the minSdk 23 that lifecycle 2.10.0
needs is no longer a blocker.

Bump lifecycle-runtime-compose in sentry-android-navigation3 from 2.8.3 to 2.10.0 and make the
uitest app resolve 2.10.0, then re-enable the check in both. Navigation 3 1.0.0 itself requires
lifecycle-runtime-compose 2.10.0, so apps using it already resolve this version.

sentry-android-fragment, sentry-android-navigation, sentry-android-replay and sentry-compose
keep the suppression: they get lifecycle through compileOnly dependencies pinned to the oldest
versions we support, and compiling against 2.10.0 would let them call APIs missing at runtime.

Fixes #6541

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@linear-code

linear-code Bot commented Nov 18, 2026

Copy link
Copy Markdown

JAVA-832

@github-actions github-actions Bot added risk: high PR risk score: high and removed risk: high PR risk score: high labels Nov 18, 2026
@sentry

sentry Bot commented Nov 18, 2026

Copy link
Copy Markdown

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
SDK Size io.sentry.tests.size 8.64.0 (1) release

⚙️ sentry-android Build Distribution Settings

@runningcode
runningcode marked this pull request as ready for review November 19, 2026 15:26
@runningcode
runningcode requested review from a team and adinauer as code owners November 19, 2026 15:26
@runningcode
runningcode requested review from 0xadam-brown and romtsn and removed request for a team November 19, 2026 15:26
@github-actions github-actions Bot added risk: high PR risk score: high and removed risk: high PR risk score: high labels Nov 19, 2026
@github-actions

Copy link
Copy Markdown
Contributor

PR risk: high

For commit 32f9da0.

Main concerns: dependencies customers inherit, reach, public contract.

Rules that block low also fired:

  • R5: dependencies or bundled SDK versions changed: gradle/libs.versions.toml
  • R6: build or release configuration changed: gradle/libs.versions.toml, sentry-android-integration-tests/sentry-uitest-android/build.gradle.kts, sentry-android-navigation3/build.gradle.kts

This label is a hint for reviewers, not an approval.

@github-actions github-actions Bot added risk: high PR risk score: high and removed risk: high PR risk score: high labels Nov 19, 2026

@0xadam-brown 0xadam-brown left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. (Nav3 1.0.0 already requires Lifecycle 2.10.0, and – fwiw – sentry-android-navigation3's use of androidx-lifecycle-runtime-compose will become compileOnly soon.)

@runningcode
runningcode merged commit 4c4848a into 9.x.x Nov 19, 2026
51 of 72 checks passed
@runningcode
runningcode deleted the no/java-832-lifecycle-2-10 branch November 19, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: high PR risk score: high

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants