Repository navigation
build(deps): Bump androidx.lifecycle to 2.10.0 in Nav3 and uitests - #6664
Merged
Merged
Conversation
Lint 9.5 can't load the custom lint checks of lifecycle releases before 2.10.0, so #6540 disabled ObsoleteLintCustomCheck. 9.x.x is on minSdk 24, so the minSdk 23 that lifecycle 2.10.0 needs is no longer a blocker. Bump lifecycle-runtime-compose in sentry-android-navigation3 from 2.8.3 to 2.10.0 and make the uitest app resolve 2.10.0, then re-enable the check in both. Navigation 3 1.0.0 itself requires lifecycle-runtime-compose 2.10.0, so apps using it already resolve this version. sentry-android-fragment, sentry-android-navigation, sentry-android-replay and sentry-compose keep the suppression: they get lifecycle through compileOnly dependencies pinned to the oldest versions we support, and compiling against 2.10.0 would let them call APIs missing at runtime. Fixes #6541 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
📲 Install BuildsAndroid
|
runningcode
marked this pull request as ready for review
November 19, 2026 15:26
runningcode
requested review from
0xadam-brown and
romtsn
and removed request for
a team
November 19, 2026 15:26
Contributor
PR risk: highFor commit Main concerns: dependencies customers inherit, reach, public contract. Rules that block low also fired:
This label is a hint for reviewers, not an approval. |
0xadam-brown
approved these changes
Nov 19, 2026
0xadam-brown
left a comment
Member
There was a problem hiding this comment.
Lgtm. (Nav3 1.0.0 already requires Lifecycle 2.10.0, and – fwiw – sentry-android-navigation3's use of androidx-lifecycle-runtime-compose will become compileOnly soon.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Problem, AGP's lint can't load the lint checks in androidx.lifecycle 2.8.3 so we had to enable supressing
ObsoleteLintCustomCheck.We previously couldn't bump this becuase it requires a minSdk of 24 so we couldn't do anything. Now that we have minSdk 24 on 9.x.x, we can bump and remove the obsolete custom lint check.
💡 Motivation and Context
Fixes #6541
Linear: JAVA-832
Lifecycle 2.10.0 needs minSdk 23, so only 9.x.x, which is on minSdk 24, can take it.
💚 How did you test it?
With the check re-enabled, lint is clean for
sentry-android-navigation3in the root build and forsentry-uitest-androidin thesentry-android-integration-testsbuild. The navigation3 unit tests pass.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
The other four modules can drop the suppression once v9 raises their minimum supported AndroidX versions to ones that pull lifecycle 2.10.0 or newer.
🤖 Generated with Claude Code