Repository navigation
ref: Remove the remaining Throwable catches that guard nothing (JAVA-552) - #6668
Draft
runningcode wants to merge 1 commit into
Draft
runningcode wants to merge 1 commit into
runningcode wants to merge 1 commit into
Conversation
The catches in ClientReportRecorder.recordLostEnvelope and recordLostEvent wrap callees that already catch their own failures, and the one in ContextUtils wraps a read of split APK info that DeviceInfoUtil has already cached. Refs #5513 Refs JAVA-552 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 18, 2026
This was referenced Nov 18, 2026
Closed
📲 Install BuildsAndroid
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Remove 3
catch (Throwable)blocks that guard nothing:ClientReportRecorder.recordLostEnvelopeandrecordLostEvent: their callees,recordLostEnvelopeItemandexecuteOnDiscard, already catch their own failures, and the rest only updates counters.ContextUtils, around the split APK info:DeviceInfoUtil.getSplitApksInfo()returns a field it filled in its constructor.No behavior changes.
💡 Motivation and Context
This is part of the
catch (Throwable)audit. #6565 removed the first 15 of these. These three came out of the boundary pass in #6657 and #6658.This PR is independent of its siblings and they can merge in any order:
rethrowIfFatalat boundary sitesLinkageErroris expectedUserInteractionTeststhread-safe list💚 How did you test it?
sentryandsentry-android-core.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
#skip-changelog
🤖 Generated with Claude Code