Repository navigation
fix: Stop swallowing errors in three places the Throwable audit found (JAVA-552) - #6670
Draft
runningcode wants to merge 3 commits into
Draft
runningcode wants to merge 3 commits into
runningcode wants to merge 3 commits into
Conversation
QueueFile deleted its file when reading it ran out of memory, as if the file were corrupt. It now resets the file only for the IndexOutOfBoundsException that a corrupt file causes. Installation wrapped an OutOfMemoryError in a RuntimeException. It now wraps only the IOException from reading or writing the installation file. The Ktor client integration swallowed coroutine cancellation while reading the response body for a failed-request event. It now rethrows CancellationException and fatal errors. Refs #5513 Refs JAVA-552 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 18, 2026
5 of 9 tasks
📲 Install BuildsAndroid
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Fix three bugs that the
catch (Throwable)audit found:QueueFiledeleted its file when reading it ran out of memory, as if the file were corrupt. It now resets the file only for theIndexOutOfBoundsExceptionthat a corrupt file causes, so the offline cache keeps its queue.Installationwrapped anOutOfMemoryErrorin aRuntimeException, which its callers catch. It now wraps only theIOExceptionfrom reading or writing the installation file.CancellationException, and callsExceptionUtils.rethrowIfFatalfor anything else the HTTP engine throws.That's 3 sites.
Mixed sites
rethrowIfFataland a comment here instead of in fix: Rethrow fatal errors at the SDK's boundary catches (JAVA-552) #6665.💡 Motivation and Context
This is part of the
catch (Throwable)audit. It replaces the three bug fixes in #6562.This PR is independent of its siblings and they can merge in any order:
rethrowIfFatalat boundary sitesLinkageErroris expectedUserInteractionTeststhread-safe list💚 How did you test it?
sentry,sentry-android-coreandsentry-ktor-client.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
The changelog entry for the whole set is in #6665.
#skip-changelog
🤖 Generated with Claude Code