Skip to content

ref(nav3): [Part 1] Repackage navigation internals - #6697

Open
0xadam-brown wants to merge 1 commit into
feat/nav3-serial-name-mappers-basefrom
feat/nav3-serial-name-mappers-1
Open

0xadam-brown wants to merge 1 commit into
feat/nav3-serial-name-mappers-basefrom
feat/nav3-serial-name-mappers-1

Conversation

@0xadam-brown

@0xadam-brown 0xadam-brown commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

PR Stack (Nav3 Serial Name Mappers)


📜 Description

PR moves our non-public nav3 code into a new .internal package, and introduces an .internal.backstack package as a sibling to .internal.lifecycle.

 io/sentry/compose/navigation3/
 ├── BackStackEntryMapper.kt
 ├── SentryNavEffect.kt
 ├── SentryNavOptions.kt
-├── BackStackConverter.kt
-├── BackStackObserver.kt
-├── CoordinatedBackStackObserver.kt
-└── lifecycle/
+└── internal/
+    ├── backstack/
+    │   ├── BackStackConverter.kt
+    │   ├── BackStackObserver.kt
+    │   └── CoordinatedBackStackObserver.kt
+    └── lifecycle/

Doing so makes it obvious what the public APIs are (SentryNavEffect, SentryNavOptions, and BackStackEntryMapper), and it lets us introduce another .internal.backstack.kotlinx subpackage later in this PR stack to sequester code that calls kotlinx.serialization APIs.

This is a pure refactor / no behavioral or ABI changes.

💡 Motivation and Context

The Nav3 integration's public entry points previously shared a package with the machinery that tracks back stacks and activity ownership. As the integration grows, that arrangement makes it harder to distinguish the supported SDK surface from the state management behind it.

addresses: JAVA-787 (link)

💚 How did you test it?

n/a

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.
  • Public API changes reviewed by another Mobile SDK team member or implemented according to the develop docs spec.

🔮 Next steps

Continue with PR 2: Extract shared back stack policies.

⚠️ Merge this PR using a merge commit (not squash). Only the collection branch is squash-merged into main.

#skip-changelog

@github-actions

Copy link
Copy Markdown
Contributor

PR risk: medium

For commit 4b32d2a.

The model rated this change low. It was raised to medium because:

  • R7: the model was not confident enough that the change is low

This label is a hint for reviewers, not an approval.

@sentry

sentry Bot commented Nov 20, 2026

Copy link
Copy Markdown

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
SDK Size io.sentry.tests.size 8.65.0 (1) release

⚙️ sentry-android Build Distribution Settings

@0xadam-brown 0xadam-brown changed the title ref(nav3): [Nav3 Mappers 1] Repackage navigation internals ref(nav3): [Built-in Mappers 1] Repackage navigation internals Nov 20, 2026
@0xadam-brown 0xadam-brown changed the title ref(nav3): [Built-in Mappers 1] Repackage navigation internals ref(nav3): [Part 1] Repackage navigation internals Nov 20, 2026
@0xadam-brown
0xadam-brown marked this pull request as ready for review November 20, 2026 14:17
@0xadam-brown
0xadam-brown requested review from a team and adinauer as code owners November 20, 2026 14:17
@0xadam-brown
0xadam-brown requested review from markushi and runningcode and removed request for a team November 20, 2026 14:17
@github-actions github-actions Bot added risk: medium PR risk score: medium and removed risk: medium PR risk score: medium labels Nov 20, 2026
@0xadam-brown 0xadam-brown added the ship-it PR is ready to merge from a reviewer perspective label Nov 20, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: medium PR risk score: medium ship-it PR is ready to merge from a reviewer perspective

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant