Skip to content

build(nav3): [Part 3] Compose lifecycle dependency is now compileOnly - #6699

Open
0xadam-brown wants to merge 2 commits into
feat/nav3-serial-name-mappers-2from
feat/nav3-serial-name-mappers-3
Open

0xadam-brown wants to merge 2 commits into
feat/nav3-serial-name-mappers-2from
feat/nav3-serial-name-mappers-3

Conversation

@0xadam-brown

@0xadam-brown 0xadam-brown commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

PR Stack (Nav3 Serial Name Mappers)


📜 Description

sentry-android-navigation3 no longer supplies its own version of the Compose lifecycle dependency, but instead relies on the host app to provide it, ie, we now use a compileOnly config rather than implementation.

Let's us match the common sentry-java convention and avoids running the risk of dependabot updating the dependency at some point and bringing host apps along for the ride.

(The original use of implementation rather than compileOnly was a clanker decision rather than being principled / meaningful.)

Update does not affect any existing Nav3 applications who consume sentry-android-navigation3.

💡 Motivation and Context

Nav3 applications already depend on lifecycle Compose through navigation3-ui, which is an inevitable part of the application's AndroidX dependency graph.

addresses: JAVA-787 (link)

💚 How did you test it?

n/a

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.
  • Public API changes reviewed by another Mobile SDK team member or implemented according to the develop docs spec.

🔮 Next steps

Continue with PR 4: Preserve events with non-finite arguments.

⚠️ Merge this PR using a merge commit (not squash). Only the collection branch is squash-merged into main.

@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

PR risk: medium

For commit 215dc27.

Main concerns: dependencies customers inherit, public contract, reach.

Rules that block low also fired:

  • R6: build or release configuration changed: sentry-android-navigation3/build.gradle.kts

This label is a hint for reviewers, not an approval.

@sentry

sentry Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
SDK Size io.sentry.tests.size 8.65.0 (1) release

⚙️ sentry-android Build Distribution Settings

@github-actions github-actions Bot added risk: medium PR risk score: medium and removed risk: medium PR risk score: medium labels Nov 20, 2026
@0xadam-brown 0xadam-brown changed the title build(nav3): [Nav3 Mappers 3] Let the host supply lifecycle Compose build(nav3): [Nav3 Mappers 3] Compose lifecycle dependency is now compileOnly Nov 20, 2026
@0xadam-brown 0xadam-brown changed the title build(nav3): [Nav3 Mappers 3] Compose lifecycle dependency is now compileOnly build(nav3): [Part 3] Compose lifecycle dependency is now compileOnly Nov 20, 2026
@0xadam-brown
0xadam-brown marked this pull request as ready for review November 20, 2026 14:19
@0xadam-brown
0xadam-brown requested review from a team and adinauer as code owners November 20, 2026 14:19
@0xadam-brown
0xadam-brown requested review from markushi and runningcode and removed request for a team November 20, 2026 14:19
@github-actions github-actions Bot removed the risk: medium PR risk score: medium label Nov 20, 2026
@github-actions github-actions Bot added the risk: medium PR risk score: medium label Nov 20, 2026
@0xadam-brown 0xadam-brown added the ship-it PR is ready to merge from a reviewer perspective label Nov 20, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: medium PR risk score: medium ship-it PR is ready to merge from a reviewer perspective

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant