Repository navigation
ref(nav3): [Part 6] Share bounded argument conversion - #6702
Draft
0xadam-brown wants to merge 2 commits into
Draft
0xadam-brown wants to merge 2 commits into
0xadam-brown wants to merge 2 commits into
Conversation
This was referenced Nov 20, 2026
Contributor
PR risk: mediumFor commit Main concerns: data sent to Sentry, dependencies customers inherit, reach. Rules that block low also fired:
This label is a hint for reviewers, not an approval. |
📲 Install BuildsAndroid
|
This was referenced Nov 20, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (Nav3 Serial Name Mappers)
📜 Description
PR introduces the
ArgumentSource<>ArgumentSinkpair that lets us support differentiated processing on the source side (the host app's logic vs built-in mapper logic) but uniform processing on the sink side (argument pruning, protecting against constraint violation, and argument tree materialization). Absent that pair, we'd have to duplicate the latter for our built-in mappers, causing them to processing the argument tree twice.💡 Motivation and Context
With Nav3, host apps manage their own nav back stack, which they implement as a list of arbitrarily typed entries. In order to be displayed in Sentry, each of those entries has to be mapped to a Sentry name (e.g., ProductDetailScreen) and zero or more arguments (e.g., productId). There are two ways for host apps to provide us with those mappings:
BackStackEntryMapper; orBackStackEntryMapper.SerialNameorBackStackEntryMapper.SerialNameAndProperties).As mentioned above, the new
ArgumentSinkandArgumentSourcetypes let custom and built-in mappers apply different processing procedures, while sending the outputs of both through the shared sink pipeline. (Fyi, we accept custom mapper output as-is, but we filter built-in mapper properties through Sentry's sensitive denylist.)Here are the moving parts:
addresses: JAVA-787 (link)
💚 How did you test it?
Nav3 release build and all 561 unit tests passed. Repository-wide
make format api, Spotless checks, ABI validation, and Detekt passed.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Continue with PR 7: Add the SerialName mapper.
#skip-changelog