Repository navigation
feat(nav3): [Part 7] Add the SerialName mapper - #6703
Draft
0xadam-brown wants to merge 2 commits into
Draft
0xadam-brown wants to merge 2 commits into
0xadam-brown wants to merge 2 commits into
Conversation
This was referenced Nov 20, 2026
Contributor
|
This was referenced Nov 20, 2026
📲 Install BuildsAndroid
|
This was referenced Nov 20, 2026
Contributor
PR risk: not classifiedFor commit The last run ended with status |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (Nav3 Serial Name Mappers)
📜 Description
BackStackEntryMapper.SerialNameuses a route’s kotlinx.serialization serial name as its Sentry destination name without collecting route properties.A route whose name cannot be resolved is shown as
/unknown, with a diagnostic warning available when SDK debugging is enabled. An unsupported route type or an incompatible serialization runtime should therefore leave a visible gap in naming rather than crash navigation or silently remove the destination from the recorded back stack.💡 Motivation and Context
Apps that use kotlinx.serialization already give each serializable route a name that does not depend on its obfuscated runtime class name. Reusing that naming contract avoids requiring applications to write a mapper for every route type.
addresses: JAVA-787 (link)
💚 How did you test it?
Nav3 release build and all 652 unit tests passed. Repository-wide
make format api, Spotless checks, ABI validation, and Detekt passed.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Continue with PR 8: Define bounded property encoding.