Skip to content

feat(nav3): [Part 7] Add the SerialName mapper - #6703

Draft
0xadam-brown wants to merge 2 commits into
feat/nav3-serial-name-mappers-6from
feat/nav3-serial-name-mappers-7
Draft

0xadam-brown wants to merge 2 commits into
feat/nav3-serial-name-mappers-6from
feat/nav3-serial-name-mappers-7

Conversation

@0xadam-brown

@0xadam-brown 0xadam-brown commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

PR Stack (Nav3 Serial Name Mappers)


📜 Description

BackStackEntryMapper.SerialName uses a route’s kotlinx.serialization serial name as its Sentry destination name without collecting route properties.

A route whose name cannot be resolved is shown as /unknown, with a diagnostic warning available when SDK debugging is enabled. An unsupported route type or an incompatible serialization runtime should therefore leave a visible gap in naming rather than crash navigation or silently remove the destination from the recorded back stack.

💡 Motivation and Context

Apps that use kotlinx.serialization already give each serializable route a name that does not depend on its obfuscated runtime class name. Reusing that naming contract avoids requiring applications to write a mapper for every route type.

addresses: JAVA-787 (link)

💚 How did you test it?

Nav3 release build and all 652 unit tests passed. Repository-wide make format api, Spotless checks, ABI validation, and Detekt passed.

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.
  • Public API changes reviewed by another Mobile SDK team member or implemented according to the develop docs spec.

🔮 Next steps

Continue with PR 8: Define bounded property encoding.

⚠️ Merge this PR using a merge commit (not squash). Only the collection branch is squash-merged into main.

@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 8e69a38

@sentry

sentry Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
SDK Size io.sentry.tests.size 8.65.0 (1) release

⚙️ sentry-android Build Distribution Settings

@github-actions github-actions Bot added the risk: medium PR risk score: medium label Nov 20, 2026
@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

PR risk: not classified

For commit 8e69a38.

The last run ended with status provider_error, so this pull request has no risk label.

@github-actions github-actions Bot removed the risk: medium PR risk score: medium label Nov 20, 2026
@0xadam-brown 0xadam-brown changed the title feat(nav3): [Nav3 Mappers 7] Add the SerialName mapper feat(nav3): [Part 7] Add the SerialName mapper Nov 20, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant