Skip to content

feat(nav3): [Part 8] Define bounded property encoding - #6705

Draft
0xadam-brown wants to merge 2 commits into
feat/nav3-serial-name-mappers-7from
feat/nav3-serial-name-mappers-8
Draft

0xadam-brown wants to merge 2 commits into
feat/nav3-serial-name-mappers-7from
feat/nav3-serial-name-mappers-8

Conversation

@0xadam-brown

@0xadam-brown 0xadam-brown commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

PR Stack (Nav3 Serial Name Mappers)


📜 Description

Route properties can now be encoded as navigation arguments subject to size and structural limits, with sensitive-key filtering applied to nested data. This policy is introduced before the properties mapper becomes public.

Values under keys matching Sentry's sensitive denylist are filtered, including within nested data. That is a limited safeguard for common secrets, not a general PII filter: applications must still decide which route properties are appropriate to send. The public mapper introduced next makes that choice explicit.

💡 Motivation and Context

Automatically turning route properties into navigation arguments needs a consistent policy for nested data, payload limits, and fields that contain secrets. The built-in path should follow the same structural rules as custom mapper output.

addresses: JAVA-787 (link)

💚 How did you test it?

Nav3 release build and all 752 unit tests passed. Repository-wide make format api, Spotless checks, ABI validation, and Detekt passed. The 10 affected HttpUtils tests also passed.

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.
  • Public API changes reviewed by another Mobile SDK team member or implemented according to the develop docs spec.

🔮 Next steps

Continue with PR 9: Add SerialNameAndProperties.

⚠️ Merge this PR using a merge commit (not squash). Only the collection branch is squash-merged into main.

#skip-changelog

@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 546f3b8

@github-actions github-actions Bot added the risk: medium PR risk score: medium label Nov 20, 2026
@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

PR risk: medium

For commit 546f3b8.

Main concerns: public contract, data sent to Sentry, reach.

Rules that block low also fired:

  • R4: a public API record changed: sentry/api/sentry.api

This label is a hint for reviewers, not an approval.

@sentry

sentry Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
SDK Size io.sentry.tests.size 8.65.0 (1) release

⚙️ sentry-android Build Distribution Settings

@github-actions github-actions Bot added risk: medium PR risk score: medium and removed risk: medium PR risk score: medium labels Nov 20, 2026
@0xadam-brown 0xadam-brown changed the title feat(nav3): [Nav3 Mappers 8] Define bounded property encoding feat(nav3): [Part 8] Define bounded property encoding Nov 20, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: medium PR risk score: medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant