Repository navigation
test(nav3): [Part 11] Verify mapping after R8 minification - #6708
Draft
0xadam-brown wants to merge 1 commit into
Draft
0xadam-brown wants to merge 1 commit into
0xadam-brown wants to merge 1 commit into
Conversation
This was referenced Nov 20, 2026
Contributor
PR risk: mediumFor commit The model rated this change low. It was raised to medium because:
This label is a hint for reviewers, not an approval. |
4 of 9 tasks
📲 Install BuildsAndroid
|
0xadam-brown
force-pushed
the
feat/nav3-serial-name-mappers-10
branch
from
November 20, 2026 14:00
7a34760 to
f7b850a
Compare
0xadam-brown
force-pushed
the
feat/nav3-serial-name-mappers-11
branch
from
November 20, 2026 14:00
5ddd798 to
7d85cf6
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (Nav3 Serial Name Mappers)
📜 Description
The compatibility checks exercise both built-in mappers in R8-minified app builds against the supported serialization floor and a pinned latest version, in both full and compatibility modes. The application determines its serialization runtime, so the checks cover both the SDK’s compilation floor and a newer runtime.
💡 Motivation and Context
The built-in mappers must honor serialization names and property filtering after an application's code has been minified. Ordinary unit tests cannot establish that contract because they do not exercise the optimizer or the rules that keep serializer lookup available in the app. Running the mapping checks inside a genuinely minified app makes those compatibility failures visible before an SDK release.
addresses: JAVA-787 (link)
💚 How did you test it?
All four R8 configurations passed on an API 36 emulator: full and compatibility modes, each with serialization 1.7.3 and 1.13.0. All 872 Nav3 unit tests also passed against serialization 1.13.0. The fixture release build, sample build, repository-wide formatting/API generation, and Nav3 checks passed.
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Continue with PR 12: Keep compatibility coverage current.
#skip-changelog