Skip to content

test(nav3): [Part 11] Verify mapping after R8 minification - #6708

Draft
0xadam-brown wants to merge 1 commit into
feat/nav3-serial-name-mappers-10from
feat/nav3-serial-name-mappers-11
Draft

0xadam-brown wants to merge 1 commit into
feat/nav3-serial-name-mappers-10from
feat/nav3-serial-name-mappers-11

Conversation

@0xadam-brown

@0xadam-brown 0xadam-brown commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

PR Stack (Nav3 Serial Name Mappers)


📜 Description

The compatibility checks exercise both built-in mappers in R8-minified app builds against the supported serialization floor and a pinned latest version, in both full and compatibility modes. The application determines its serialization runtime, so the checks cover both the SDK’s compilation floor and a newer runtime.

💡 Motivation and Context

The built-in mappers must honor serialization names and property filtering after an application's code has been minified. Ordinary unit tests cannot establish that contract because they do not exercise the optimizer or the rules that keep serializer lookup available in the app. Running the mapping checks inside a genuinely minified app makes those compatibility failures visible before an SDK release.

addresses: JAVA-787 (link)

💚 How did you test it?

All four R8 configurations passed on an API 36 emulator: full and compatibility modes, each with serialization 1.7.3 and 1.13.0. All 872 Nav3 unit tests also passed against serialization 1.13.0. The fixture release build, sample build, repository-wide formatting/API generation, and Nav3 checks passed.

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.
  • Public API changes reviewed by another Mobile SDK team member or implemented according to the develop docs spec.

🔮 Next steps

Continue with PR 12: Keep compatibility coverage current.

⚠️ Merge this PR using a merge commit (not squash). Only the collection branch is squash-merged into main.

#skip-changelog

@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

PR risk: medium

For commit 7d85cf6.

The model rated this change low. It was raised to medium because:

  • R6: build or release configuration changed: .github/workflows/integration-tests-nav3-r8.yml, Makefile, scripts/test-nav3-backstack-entry-mapper-r8.sh, scripts/update-nav3-kotlinx-serialization.sh, sentry-android-integration-tests/nav3-backstack-entry-mapper-r8-check/build.gradle.kts and 2 more
  • R7: the model was not confident enough that the change is low

This label is a hint for reviewers, not an approval.

@github-actions github-actions Bot added risk: medium PR risk score: medium and removed risk: medium PR risk score: medium labels Nov 20, 2026
@sentry

sentry Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
SDK Size io.sentry.tests.size 8.65.0 (1) release

⚙️ sentry-android Build Distribution Settings

@0xadam-brown
0xadam-brown force-pushed the feat/nav3-serial-name-mappers-10 branch from 7a34760 to f7b850a Compare November 20, 2026 14:00
@0xadam-brown
0xadam-brown force-pushed the feat/nav3-serial-name-mappers-11 branch from 5ddd798 to 7d85cf6 Compare November 20, 2026 14:00
@github-actions github-actions Bot added risk: medium PR risk score: medium and removed risk: medium PR risk score: medium labels Nov 20, 2026
@0xadam-brown 0xadam-brown changed the title test(nav3): [Nav3 Mappers 11] Verify mapping after R8 minification test(nav3): [Part 11] Verify mapping after R8 minification Nov 20, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: medium PR risk score: medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant