Repository navigation
ci(release): Bump craft to 3.9.0 and update config - #48
Open
sentry-junior[bot] wants to merge 2 commits into
Open
sentry-junior[bot] wants to merge 2 commits into
sentry-junior[bot] wants to merge 2 commits into
Conversation
Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bumps the release workflow's pinned
getsentry/craftaction from 2.18.3 (1c58bfd5, labeled# v2) to 3.9.0 (2e29b081), and updates.craft.ymlto match.Why: craft's "Check release blockers" step used to ask GitHub to cancel the run and then exit 0, so the later steps kept going until the cancellation landed. That's how getsentry/symbolic run 41665569364 still prepared a release and opened a getsentry/publish issue while a
release-blockerissue was open. getsentry/craft#956 fixed this in 3.9.0: the step now fails right away, and also fails if the blocker lookup errors.Config changes (
.craft.yml):minVersion2.19.0 → 3.9.0.changelogPolicy: autowithchangelog.policy: auto.preReleaseCommandandversioning.policywere already set explicitly, so the newminVersionchanges no defaults.getsentry/craft:latest, which is 3.9.0 right now, so publishing meets the newminVersion.Compatibility: I compared the action inputs at 2.18.3 and 3.9.0. Every input this workflow uses (
version,force,merge_target,craft_config_from_merge_target) still exists; 3.9.0 only adds optional ones. The config sets nochangelog.includePathsorunownedPaths, and there's no nuget target.Dry run: I ran craft 3.9.0
prepare 99.0.0 --dry-run --no-pushbefore and after the config change. Both times it ranscripts/craft-pre-release.shand changed the same files (package.jsonandCHANGELOG.md) with no errors. After the change, thechangelogPolicydeprecation warning is gone.No open
release-blockerissues in this repo right now. Once this lands, any openrelease-blockerissue will stop releases until it's closed orforceis set.via @BYK.
--
View Session in Sentry