You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 5fe6aab
Browse filesBrowse the repository at this point in the historyBrowse files
ref(node): Stop using registerSpanErrorInstrumentation() on server (#21169)
I think this does nothing on node, because the implementation of this
calls this under the hood:
```js
addGlobalErrorInstrumentationHandler(errorCallback);
addGlobalUnhandledRejectionInstrumentationHandler(errorCallback);
```
basically browser-only, using `window.onerror`. I believe this is
handled specifically in node anyhow so should not be used/needed and
allows us to streamline this a bit and potentially move this to a
browser-only place eventually.
This also means we can remove the tag we put here, because this is
actually not needed.
I adjusted a node-integration-test to verify this works there, both with
using our own startSpan implementations (express uses this). With
otel-native spans, it does not work, but it did not work before either -
IMHO this is fine for the time being.
0 commit comments