Skip to content

feat(ndk): Forward enable_logs option to sentry-native #1971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
romtsn merged 3 commits into from
Aug 11, 2026
Merged

feat(ndk): Forward enable_logs option to sentry-native #1971

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c28bf73
feat(ndk): Forward `enable_logs` option to sentry-native
romtsn Aug 10, 2026
5671ad2
fix: Update API dump and add changelog entry
romtsn Aug 10, 2026
1aaba14
Merge branch 'master' into roman/forward-enable-logs-ndk
romtsn Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions ndk/lib/src/main/java/io/sentry/ndk/NdkOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ public final class NdkOptions {
private float tracesSampleRate = 0;
private boolean enableAppHangTracking = false;
private long appHangTimeoutMillis = 5000;
private boolean enableLogs = false;

public NdkOptions(
@NotNull String dsn,
Expand Down Expand Up @@ -106,4 +107,12 @@ public void setAppHangTimeoutMillis(final long appHangTimeoutMillis) {
public long getAppHangTimeoutMillis() {
return appHangTimeoutMillis;
}

public void setEnableLogs(final boolean enableLogs) {
this.enableLogs = enableLogs;
}

public boolean isEnableLogs() {
return enableLogs;
}
}
7 changes: 7 additions & 0 deletions ndk/lib/src/main/jni/sentry.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,6 +417,9 @@ Java_io_sentry_ndk_SentryNdk_initSentryNative(
jmethodID app_hang_timeout_mid = (*env)->GetMethodID(
env, options_cls, "getAppHangTimeoutMillis", "()J");

jmethodID enable_logs_mid
= (*env)->GetMethodID(env, options_cls, "isEnableLogs", "()Z");

(*env)->DeleteLocalRef(env, options_cls);

char *outbox_path = NULL;
Expand Down Expand Up @@ -522,6 +525,10 @@ Java_io_sentry_ndk_SentryNdk_initSentryNative(
}
sentry_options_set_app_hang_timeout(options, (uint64_t)app_hang_timeout);

jboolean enable_logs = (jboolean)(*env)->CallBooleanMethod(
env, sentry_ndk_options, enable_logs_mid);
sentry_options_set_enable_logs(options, enable_logs);
Comment thread
romtsn marked this conversation as resolved.

int rv = sentry_init(options);
return (jint)rv;

Expand Down
Loading