Repository navigation
ci(release): Bump craft to 3.9.0 and update config - #6984
Merged
Merged
Conversation
Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
sentry-junior
Bot
requested review from
a team and
lucas-zimerman
as code owners
November 3, 2026 21:02
sentry-junior
Bot
requested review from
alwx and
antonis
and removed request for
a team
November 3, 2026 21:02
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
Contributor
Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
alwx
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
This bumps the pinned
getsentry/craftaction inrelease.ymlfrom 3.5.0 (3f1f02d5) and the craftchangelog-preview.ymlreusable workflow from 3.4.1 (90e8e203, labeled# v3) to 3.9.0 (2e29b081). The changelog-preview workflow's contents are the same at both refs, so that line only keeps the two craft pins in sync.💡 Motivation and Context
craft's "Check release blockers" step used to ask GitHub to cancel the run and then exit 0, so the action kept going and could still prepare a release and open a getsentry/publish issue while a
release-blockerissue was open (seen in getsentry/symbolic). getsentry/craft#956 fixed this in 3.9.0: the step now fails right away, and it also fails if the blocker lookup errors.BYK (a craft maintainer) asked for this bump across the repos that pin an older craft.
There are no open
release-blockerissues in this repo right now. Once this lands, any open one stops releases until it's closed orforceis set.💚 How did you test it?
This repo is already on craft 3.x, so the 3.0 breaking changes were already in effect. For the record: there's no
changelog.includePaths/unownedPaths, no nuget target, andpreReleaseCommandis set. The workflow's action inputs (version,force,merge_target) are unchanged in 3.9.0.I ran the craft 3.9.0 binary with
prepare 99.0.0 --dry-run --no-pushon currentmain. Craft loaded the config and ranscripts/craft-pre-release.sh, which then stopped atyarn installbecause yarn isn't installed where I ran it. That's a local toolchain gap, not a craft error; the release workflow sets up corepack and Node before craft runs.Config changes (follow-up commit, so
.craft.ymlmatches craft 3.9.0):Sets
minVersionfrom 0.23.1 to 3.9.0. The old minVersion meant themanualversioning policy by default, so this addsversioning.policy: manualto keep it.preReleaseCommandwas already explicit. This also replaces the deprecated top-levelchangelogPolicy: autowithchangelog.policy: auto.I ran craft 3.9.0
prepare 99.0.0 --dry-run --no-pushbefore and after this change on a full clone. Both runs loaded the config and stopped at the same missing-yarnstep inscripts/craft-pre-release.sh, which is a local toolchain gap. ThechangelogPolicydeprecation warning is gone.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
via @BYK.
--
View Session in Sentry