Skip to content

Commit 22aee99

Browse files
authored
types: Trim down the weaklist (#127894)
There's been lots of deletion and annotation that allow us to trim down a few dozen lines.
1 parent 33bf0c1 commit 22aee99

1 file changed

Lines changed: 0 additions & 45 deletions

File tree

‎pyproject.toml‎

Lines changed: 0 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -415,7 +415,6 @@ disable_error_code = [
415415
]
416416
# end: sentry modules with typing issues
417417

418-
# python3 -m tools.mypy_helpers.make_weaklist
419418
# begin: not yet strongly typed
420419
# - Moving a module from the "typing issues" list above to here is already a valuable improvement!
421420
# - To fully resolve: remove the module from this list once it is fully typed.
@@ -657,7 +656,6 @@ module = [
657656
"sentry.api.serializers.rest_framework.environment",
658657
"sentry.api.serializers.rest_framework.groupsearchview",
659658
"sentry.api.serializers.rest_framework.list",
660-
"sentry.api.serializers.rest_framework.notification_action",
661659
"sentry.api.serializers.rest_framework.origin",
662660
"sentry.api.serializers.rest_framework.project",
663661
"sentry.api.serializers.rest_framework.project_key",
@@ -892,14 +890,12 @@ module = [
892890
"sentry.integrations.msteams.link_identity",
893891
"sentry.integrations.msteams.linkage",
894892
"sentry.integrations.msteams.metrics",
895-
"sentry.integrations.msteams.notifications",
896893
"sentry.integrations.msteams.parsing",
897894
"sentry.integrations.msteams.spec",
898895
"sentry.integrations.msteams.unlink_identity",
899896
"sentry.integrations.msteams.urls",
900897
"sentry.integrations.msteams.utils",
901898
"sentry.integrations.msteams.webhook",
902-
"sentry.integrations.notifications",
903899
"sentry.integrations.on_call.*",
904900
"sentry.integrations.opsgenie",
905901
"sentry.integrations.opsgenie.actions.*",
@@ -916,7 +912,6 @@ module = [
916912
"sentry.integrations.slack.integration",
917913
"sentry.integrations.slack.message_builder.*",
918914
"sentry.integrations.slack.metrics",
919-
"sentry.integrations.slack.notifications",
920915
"sentry.integrations.slack.sdk_client",
921916
"sentry.integrations.slack.service",
922917
"sentry.integrations.slack.spec",
@@ -1110,7 +1105,6 @@ module = [
11101105
"sentry.models.rollbackorganization",
11111106
"sentry.models.rollbackuser",
11121107
"sentry.models.rule",
1113-
"sentry.models.rulesnooze",
11141108
"sentry.models.savedsearch",
11151109
"sentry.models.search_common",
11161110
"sentry.models.sentryshot",
@@ -1143,25 +1137,11 @@ module = [
11431137
"sentry.net.http",
11441138
"sentry.new_migrations.*",
11451139
"sentry.newsletter.*",
1146-
"sentry.notifications",
1147-
"sentry.notifications.additional_attachment_manager",
11481140
"sentry.notifications.api.endpoints.*",
11491141
"sentry.notifications.api.serializers.*",
1150-
"sentry.notifications.apps",
1151-
"sentry.notifications.class_manager",
1152-
"sentry.notifications.defaults",
1153-
"sentry.notifications.helpers",
11541142
"sentry.notifications.models.*",
1155-
"sentry.notifications.notification_action",
1156-
"sentry.notifications.notification_action.action_validation",
11571143
"sentry.notifications.notification_action.grouptype",
1158-
"sentry.notifications.notification_action.registry",
1159-
"sentry.notifications.notification_action.types",
1160-
"sentry.notifications.notification_action.utils",
11611144
"sentry.notifications.notificationcontroller",
1162-
"sentry.notifications.notify",
1163-
"sentry.notifications.serializers",
1164-
"sentry.notifications.types",
11651145
"sentry.notifications.validators",
11661146
"sentry.objectstore.*",
11671147
"sentry.onboarding_tasks.*",
@@ -1220,14 +1200,8 @@ module = [
12201200
"sentry.replays.testutils",
12211201
"sentry.replays.usecases.*",
12221202
"sentry.replays.validators",
1223-
"sentry.rules",
1224-
"sentry.rules.actions",
1225-
"sentry.rules.actions.base",
1226-
"sentry.rules.actions.notify_event_service",
1227-
"sentry.rules.actions.services",
12281203
"sentry.rules.filters.*",
12291204
"sentry.rules.processing.*",
1230-
"sentry.rules.registry",
12311205
"sentry.scm.*",
12321206
"sentry.sdk_updates",
12331207
"sentry.search",
@@ -1808,7 +1782,6 @@ module = [
18081782
"tests.sentry.integrations.test_issues",
18091783
"tests.sentry.integrations.test_metric_alerts",
18101784
"tests.sentry.integrations.test_model",
1811-
"tests.sentry.integrations.test_notification_utilities",
18121785
"tests.sentry.integrations.test_pipeline",
18131786
"tests.sentry.integrations.utils.*",
18141787
"tests.sentry.integrations.vsts.*",
@@ -1884,8 +1857,6 @@ module = [
18841857
"tests.sentry.models.test_releaseprojectenvironment",
18851858
"tests.sentry.models.test_repository",
18861859
"tests.sentry.models.test_repositorysettings",
1887-
"tests.sentry.models.test_rule",
1888-
"tests.sentry.models.test_rulesnooze",
18891860
"tests.sentry.models.test_statistical_detectors",
18901861
"tests.sentry.models.test_team",
18911862
"tests.sentry.models.test_teamkeytransaction",
@@ -1906,21 +1877,12 @@ module = [
19061877
"tests.sentry.monitors.test_utils",
19071878
"tests.sentry.monitors.test_validators",
19081879
"tests.sentry.newsletter.*",
1909-
"tests.sentry.notifications",
19101880
"tests.sentry.notifications.api.*",
1911-
"tests.sentry.notifications.notification_action",
19121881
"tests.sentry.notifications.notification_action.test_group_type_notification_registry_handlers",
1913-
"tests.sentry.notifications.notification_action.test_grouptype",
19141882
"tests.sentry.notifications.notification_action.test_issue_alert_registry_handlers",
19151883
"tests.sentry.notifications.notification_action.test_metric_alert_registry_handlers",
1916-
"tests.sentry.notifications.notifications",
19171884
"tests.sentry.notifications.notifications.test_assigned",
1918-
"tests.sentry.notifications.notifications.test_digests",
1919-
"tests.sentry.notifications.notifications.test_organization_request",
19201885
"tests.sentry.notifications.notifications.test_suspect_commits_activity",
1921-
"tests.sentry.notifications.test_apps",
1922-
"tests.sentry.notifications.test_class_manager",
1923-
"tests.sentry.notifications.test_helpers",
19241886
"tests.sentry.notifications.test_notificationcontroller",
19251887
"tests.sentry.notifications.test_notifications",
19261888
"tests.sentry.notifications.test_utils",
@@ -1956,13 +1918,7 @@ module = [
19561918
"tests.sentry.relocation",
19571919
"tests.sentry.relocation.tasks.*",
19581920
"tests.sentry.relocation.test_utils",
1959-
"tests.sentry.rules",
1960-
"tests.sentry.rules.actions",
19611921
"tests.sentry.rules.actions.test_create_ticket_utils",
1962-
"tests.sentry.rules.actions.test_notify_event_sentry_app",
1963-
"tests.sentry.rules.actions.test_notify_event_service",
1964-
"tests.sentry.rules.conditions.*",
1965-
"tests.sentry.rules.processing",
19661922
"tests.sentry.runner",
19671923
"tests.sentry.runner.commands",
19681924
"tests.sentry.runner.commands.test_backup",
@@ -2251,7 +2207,6 @@ module = [
22512207
"tests.snuba.incidents.*",
22522208
"tests.snuba.preprod.*",
22532209
"tests.snuba.processing_errors.*",
2254-
"tests.snuba.rules.*",
22552210
"tests.snuba.search.*",
22562211
"tests.snuba.sessions.*",
22572212
"tests.snuba.tagstore.*",

0 commit comments

Comments
 (0)