test(integrations): Mock Slack, Discord, Jira, and Sentry App calls in tests (#127946)

The outbound network guard in report mode (#127944) found 14 integration
tests that make real requests to `slack.com`, `discord.com`,
`example.atlassian.net`, or `example.com`. Some of them only pass
because of what the real service sends back. For example,
`test_post_message_failure_sdk` asserts the `ok=False, status=200`
metric that Slack's real `invalid_auth` reply produces.

Each test now uses a mock pattern that already exists in the same file:

- **Slack SDK** (it sends with urllib, so `responses` never matches):
- `tasks/test_tasks.py::test_post_message_failure_sdk` and
`service/test_slack_service.py::test_send_notification_to_slack_channel_error`
patch `_perform_urllib_http_request` to return the `invalid_auth` reply
the tests depended on, like their success-path neighbors do.
- `test_notify_action.py::test_invalid_channel_selected` had `responses`
mocks that could never match. It now uses the file's own
`mock_msg_schedule_response("channel_not_found")` and
`mock_list("users", ...)` helpers, which return the same data.
- `utils/test_channel.py::test_invalid_channel_selected_sdk_client` also
patches `users_list` with an empty member list.
- `webhooks/events/test_app_mention.py`: an autouse `set_thread_status`
patch, the same one `test_direct_message.py` uses.
`test_app_mention_only_mentions_halts` also patches
`send_threaded_ephemeral_message`, like its sibling halt tests.
- **Discord** `test_issue_alert.py::test_no_channel_id`: `responses`
returns a 400 for `GET /channels/`, and the test now asserts that the
mocked call happened.
- **Jira** `test_integration.py::JiraApiPipelineTest::test_install`:
when the install response serializes the org config, it fetches the
project list. `responses` now returns a 401 for that request, which
leads to the `ApiError` handling the real request hit.
- **Sentry Apps**
`test_disabled_sentry_app.py::test_delete_installation_of_disabled_app_allowed`:
the uninstall webhook is mocked the way
`test_organization_sentry_app_installation_details.py::test_delete_install`
does it.

No assertions were removed or weakened. This PR only changes tests and
doesn't depend on #127944. I ran every touched file locally with
`SENTRY_NETWORK_GUARD=strict`: they pass, and the guard records no
outbound attempts.

<!-- junior-request-attribution:start -->
via @joshuarli.
<!-- junior-request-attribution:end -->

<!-- junior-session-footer:start -->
<!-- junior-conversation-id:agent%3A35c0cbe32045897a494787cce713d692 -->

--

[View Junior
Session](https://junior-prod.sentry.dev/conversations/agent%3A35c0cbe32045897a494787cce713d692)
[[Sentry]](https://sentry.sentry.io/explore/conversations/agent%3A35c0cbe32045897a494787cce713d692/?project=4510944073809921)

<!-- junior-session-footer:end -->

Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com>
Co-authored-by: Joshua Li <14209781+joshuarli@users.noreply.github.com>

Author: sentry-junior[bot]

tests/sentry/integrations/discord/test_issue_alert.py

@@ -9,7 +9,7 @@
 from sentry.integrations.discord.actions.issue_alert.form import DiscordNotifyServiceForm
 from sentry.integrations.discord.actions.issue_alert.notification import DiscordNotifyServiceAction
 from sentry.integrations.discord.analytics import DiscordIntegrationNotificationSent
-from sentry.integrations.discord.client import DISCORD_BASE_URL, MESSAGE_URL
+from sentry.integrations.discord.client import CHANNEL_URL, DISCORD_BASE_URL, MESSAGE_URL
 from sentry.integrations.discord.message_builder import LEVEL_TO_COLOR
 from sentry.integrations.discord.message_builder.base.component import DiscordComponentCustomIds
 from sentry.integrations.messaging.message_builder import (
@@ -328,14 +328,21 @@ def test_valid(self, mock_validate_channel_id: mock.MagicMock) -> None:
         assert self.form.is_valid()
         assert mock_validate_channel_id.call_count == 1
 
+    @responses.activate
     @mock.patch(
         "sentry.integrations.discord.actions.issue_alert.form.get_channel_id_from_url",
         return_value="",
     )
     def test_no_channel_id(self, mock_get_channel_id_from_url: mock.MagicMock) -> None:
+        responses.add(
+            responses.GET,
+            f"{DISCORD_BASE_URL}{CHANNEL_URL.format(channel_id='')}",
+            status=400,
+        )
         self.form.full_clean()
         assert not self.form.is_valid()
         assert mock_get_channel_id_from_url.call_count == 1
+        assert len(responses.calls) == 1
 
     def test_no_server(self) -> None:
         form = DiscordNotifyServiceForm(integrations=self.integrations)

tests/sentry/integrations/jira/test_integration.py

@@ -2456,7 +2456,10 @@ def test_advance_with_invalid_state_errors(self) -> None:
         assert resp.status_code == 400
         assert not Integration.objects.filter(provider=self.provider.key).exists()
 
+    @responses.activate
     def test_install(self) -> None:
+        # The install response serializes the org config, which fetches Jira projects.
+        responses.add(responses.GET, "https://example.atlassian.net/rest/api/2/project", status=401)
         resp = self._initialize_pipeline(initial_data={"signedParams": self._signed_params()})
         pipeline_signature = resp.data["data"]["state"]
 

tests/sentry/integrations/slack/service/test_slack_service.py

@@ -538,7 +538,13 @@ def test_send_notification_to_slack_channel(self, mock_api_call: mock.MagicMock)
             client=SlackSdkClient(integration_id=self.integration.id),
         )
 
-    def test_send_notification_to_slack_channel_error(self) -> None:
+    @mock.patch("slack_sdk.web.client.WebClient._perform_urllib_http_request")
+    def test_send_notification_to_slack_channel_error(self, mock_api_call: mock.MagicMock) -> None:
+        mock_api_call.return_value = {
+            "body": orjson.dumps({"ok": False, "error": "invalid_auth"}).decode(),
+            "headers": {},
+            "status": 200,
+        }
         with pytest.raises(SlackApiError) as err:
             self.service._send_notification_to_slack_channel(
                 channel_id=self.channel_id,

tests/sentry/integrations/slack/tasks/test_tasks.py

@@ -60,8 +60,17 @@ def test_post_message_success(self, mock_api_call: MagicMock, mock_metrics: Magi
         )
 
     @patch("sentry.integrations.slack.sdk_client.metrics")
+    @patch("slack_sdk.web.client.WebClient._perform_urllib_http_request")
     @responses.activate
-    def test_post_message_failure_sdk(self, mock_metrics: MagicMock) -> None:
+    def test_post_message_failure_sdk(
+        self, mock_api_call: MagicMock, mock_metrics: MagicMock
+    ) -> None:
+        mock_api_call.return_value = {
+            "body": orjson.dumps({"ok": False, "error": "invalid_auth"}).decode(),
+            "headers": {},
+            "status": 200,
+        }
+
         with self.tasks():
             post_message.apply_async(
                 kwargs={

tests/sentry/integrations/slack/test_notify_action.py

@@ -243,34 +243,19 @@ def test_valid_member_selected(self) -> None:
                 assert form.is_valid()
                 self.assert_form_valid(form, "morty-id", "@morty")
 
-    @responses.activate
     def test_invalid_channel_selected(self) -> None:
         rule = self.get_rule(
             data={"workspace": self.integration.id, "channel": "#my-channel", "tags": ""}
         )
 
-        responses.add(
-            method=responses.POST,
-            url="https://slack.com/api/chat.scheduleMessage",
-            status=200,
-            content_type="application/json",
-            body=orjson.dumps({"ok": False, "error": "channel_not_found"}),
-        )
-
-        members = {"ok": "true", "members": [{"name": "other-member", "id": "member-id"}]}
-
-        responses.add(
-            method=responses.GET,
-            url="https://slack.com/api/users.list",
-            status=200,
-            content_type="application/json",
-            body=orjson.dumps(members),
-        )
+        members = [{"name": "other-member", "id": "member-id"}]
 
-        form = SlackNotifyServiceForm(rule.data, integrations=rule.get_integrations())
+        with self.mock_msg_schedule_response("channel_not_found"):
+            with self.mock_list("users", members, "members"):
+                form = SlackNotifyServiceForm(rule.data, integrations=rule.get_integrations())
 
-        assert not form.is_valid()
-        assert len(form.errors) == 1
+                assert not form.is_valid()
+                assert len(form.errors) == 1
 
     @responses.activate
     @patch("slack_sdk.web.client.WebClient.users_list")

tests/sentry/integrations/slack/utils/test_channel.py

@@ -170,7 +170,7 @@ def test_invalid_member_selected_display_name_sdk_client(self) -> None:
                     get_channel_id(self.integration, "@Morty")
 
     def test_invalid_channel_selected_sdk_client(self) -> None:
-        with self.patch_msg_response_not_found():
+        with self.patch_msg_response_not_found(), self.patch_mock_list("users", [], "members"):
             assert get_channel_id(self.integration, "#fake-channel").channel_id is None
             assert get_channel_id(self.integration, "@fake-user").channel_id is None
 

tests/sentry/integrations/slack/webhooks/events/test_app_mention.py

@@ -1,5 +1,7 @@
 from unittest.mock import patch
 
+import pytest
+
 from sentry.integrations.messaging.metrics import SeerSlackHaltReason
 from sentry.testutils.asserts import assert_halt_metric
 
@@ -23,6 +25,13 @@ def setUp(self):
         # Tests default to having the mention come from a linked user.
         self.link_identity(user=self.user, slack_user_id=APP_MENTION_EVENT["user"])
 
+    @pytest.fixture(autouse=True)
+    def mock_set_thread_status(self):
+        with patch(
+            "sentry.integrations.slack.integration.SlackIntegration.set_thread_status",
+        ) as self.mock_status:
+            yield
+
     @patch("sentry.seer.entrypoints.slack.tasks.process_mention_for_slack.apply_async")
     def test_app_mention_dispatches_task(self, mock_apply_async):
         with self.feature(SEER_EXPLORER_FEATURES):
@@ -137,9 +146,10 @@ def test_app_mention_only_the_bot_mention_halts_without_authorizations(
         assert_halt_metric(mock_record, SeerSlackHaltReason.EMPTY_PROMPT)
         mock_send.assert_called_once()
 
+    @patch("sentry.integrations.slack.workspace.send_threaded_ephemeral_message")
     @patch("sentry.integrations.utils.metrics.EventLifecycle.record_event")
     @patch("sentry.seer.entrypoints.slack.tasks.process_mention_for_slack.apply_async")
-    def test_app_mention_only_mentions_halts(self, mock_apply_async, mock_record):
+    def test_app_mention_only_mentions_halts(self, mock_apply_async, mock_record, mock_send):
         """Mentioning us alongside other users, with no question, is still empty."""
         with self.feature(SEER_EXPLORER_FEATURES):
             resp = self.post_webhook(

tests/sentry/sentry_apps/api/bases/test_disabled_sentry_app.py

@@ -1,3 +1,5 @@
+import responses
+
 from sentry.sentry_apps.models.sentry_app import SentryApp
 from sentry.silo.base import SiloMode
 from sentry.testutils.cases import APITestCase
@@ -61,8 +63,10 @@ def test_get_installation_of_disabled_app_returns_403(self) -> None:
         disable_app(self.app)
         self.get_error_response(self.install.uuid, status_code=403)
 
+    @responses.activate
     @override_options(OPTION)
     def test_delete_installation_of_disabled_app_allowed(self) -> None:
+        responses.add(url="https://example.com/webhook", method=responses.POST, body=b"")
         disable_app(self.app)
         self.get_success_response(self.install.uuid, method="delete", status_code=204)