feat: Rename evaluate_impl to _evaluate

Author: RudraPatel2003

src/sentry/preprod/size_analysis/grouptype.py

@@ -216,7 +216,7 @@ def _matches_query(self, data_packet: SizeAnalysisDataPacket) -> bool:
             )
             return False
 
-    def evaluate_impl(self, data_packet: SizeAnalysisDataPacket) -> GroupedDetectorEvaluationResult:
+    def evaluate(self, data_packet: SizeAnalysisDataPacket) -> GroupedDetectorEvaluationResult:
         if not self._matches_query(data_packet):
             return GroupedDetectorEvaluationResult(result={}, tainted=False)
 

src/sentry/processing_errors/grouptype.py

@@ -116,7 +116,7 @@ def extract_value(
 
     @override
     def extract_dedupe_value(self, data_packet: DataPacket[ProcessingErrorPacketValue]) -> int:
-        # Not used — we override evaluate_impl and skip dedupe logic
+        # Not used — we override evaluate and skip dedupe logic
         return 0
 
     @override
@@ -167,7 +167,7 @@ def create_occurrence(
         return (occurrence, event_data)
 
     @override
-    def evaluate_impl(
+    def evaluate(
         self, data_packet: DataPacket[ProcessingErrorPacketValue]
     ) -> GroupedDetectorEvaluationResult:
         """

src/sentry/workflow_engine/docs/adding-detectors.md

@@ -30,7 +30,7 @@ flowchart TD
     State -->|No| Shared{Can use shared condition loading and metrics?}
     Shared -->|Yes| Base[Inherit BaseDetectorHandler]
     Shared -->|No| Interface[Implement DetectorHandler]
-    Base --> Own[Implement full evaluate_impl orchestration]
+    Base --> Own[Implement full evaluate orchestration]
     Interface --> OwnAll[Implement complete evaluate contract]
 ```
 
@@ -56,7 +56,7 @@ Uptime and metric issues are canonical examples.
 
 [`BaseDetectorHandler`](../handlers/detector/base.py) provides condition-group loading
 and common evaluation metrics, but it does not provide a general stateless evaluation
-algorithm. A concrete subclass must implement `evaluate_impl`, `create_occurrence`,
+algorithm. A concrete subclass must implement `evaluate`, `create_occurrence`,
 `extract_value`, and `extract_dedupe_value`; custom orchestration can provide trivial
 implementations for hooks it does not use. The subclass owns its state and output
 semantics.

src/sentry/workflow_engine/docs/conditions.md

@@ -252,7 +252,7 @@ A [`Detector`](../models/detector.py) represents configured detection. A runtime
 is selected through the detector type's [`DetectorSettings`](../types.py).
 
 The common stateful path is
-[`StatefulDetectorHandler.evaluate_impl`](../handlers/detector/stateful.py):
+[`StatefulDetectorHandler.evaluate`](../handlers/detector/stateful.py):
 
 1. Extract one packet-wide positive integer dedupe value.
 2. Extract one evaluation value or a mapping of `DetectorGroupKey` to value.

src/sentry/workflow_engine/handlers/detector/base.py

@@ -147,7 +147,7 @@ def _evaluate(
             "result": "unknown",
         }
         try:
-            value = self.evaluate_impl(data_packet)
+            value = self.evaluate(data_packet)
             tags["result"] = "tainted" if value.tainted else "success"
             metrics.incr("workflow_engine_detector.evaluation", tags=tags, sample_rate=1.0)
             return value.result
@@ -157,9 +157,7 @@ def _evaluate(
             raise
 
     @abc.abstractmethod
-    def evaluate_impl(
-        self, data_packet: DataPacket[DataPacketType]
-    ) -> GroupedDetectorEvaluationResult:
+    def evaluate(self, data_packet: DataPacket[DataPacketType]) -> GroupedDetectorEvaluationResult:
         """
         This method is used to evaluate the data packet's value against the conditions on the detector.
         """

src/sentry/workflow_engine/handlers/detector/stateful.py

@@ -410,9 +410,7 @@ def _build_workflow_engine_evidence_data(
 
         return base
 
-    def evaluate_impl(
-        self, data_packet: DataPacket[DataPacketType]
-    ) -> GroupedDetectorEvaluationResult:
+    def evaluate(self, data_packet: DataPacket[DataPacketType]) -> GroupedDetectorEvaluationResult:
         dedupe_value = self.extract_dedupe_value(data_packet)
         group_data_values = self._extract_value_from_packet(data_packet)
         state = self.state_manager.get_state_data(list(group_data_values.keys()))

tests/sentry/workflow_engine/endpoints/test_organization_detector_types.py

@@ -43,7 +43,7 @@ def setUp(self) -> None:
         self.registry_patcher.start()
 
         class MockDetectorHandler(ConditionDetectorHandler[dict[Never, Never], bool]):
-            def evaluate_impl(
+            def evaluate(
                 self, data_packet: DataPacket[dict[Never, Never]]
             ) -> GroupedDetectorEvaluationResult:
                 return GroupedDetectorEvaluationResult(

tests/sentry/workflow_engine/handlers/detector/test_base.py

@@ -110,7 +110,7 @@ class NoHandlerGroupType(GroupType):
             category = GroupCategory.METRIC.value
 
         class MockConditionDetectorHandler(ConditionDetectorHandler[dict[str, Any], int]):
-            def evaluate_impl(
+            def evaluate(
                 self, data_packet: DataPacket[dict[str, Any]]
             ) -> GroupedDetectorEvaluationResult:
                 return GroupedDetectorEvaluationResult(
@@ -145,7 +145,7 @@ def extract_dedupe_value(self, data_packet: DataPacket[dict[str, Any]]) -> int:
                 return data_packet.packet.get("dedupe", 0)
 
         class MockConditionDetectorWithUpdateHandler(ConditionDetectorHandler[dict[str, Any], int]):
-            def evaluate_impl(
+            def evaluate(
                 self, data_packet: DataPacket[dict[str, Any]]
             ) -> GroupedDetectorEvaluationResult:
                 status_change = StatusChangeMessage(