Repository navigation
feat(hybrid): Allow Identity model to be used as HCFK - #105339
Merged
alexsohn1126 merged 18 commits intoJan 9, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## alexsohn/feat/add-console-sdk-invite-constants-and-options #105339 +/- ##
============================================================================================
Coverage 80.60% 80.60%
============================================================================================
Files 9437 9437
Lines 404386 404402 +16
Branches 25655 25655
============================================================================================
+ Hits 325944 325965 +21
+ Misses 77974 77969 -5
Partials 468 468 |
…ons' into alexsohn/feat/add-outbox-generation-for-Identity
…ons' into alexsohn/feat/add-outbox-generation-for-Identity
…ons' into alexsohn/feat/add-outbox-generation-for-Identity
alexsohn1126
marked this pull request as ready for review
January 2, 2026 20:36
Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
…ons' into alexsohn/feat/add-outbox-generation-for-Identity
mujacica
approved these changes
Jan 7, 2026
markstory
approved these changes
Jan 7, 2026
markstory
left a comment
Member
There was a problem hiding this comment.
Looks good to me. As identity records are deleted, outbox messages will be saved. Processing those outboxes will create tombstones in all regions to cascade the deletes.
Base automatically changed from
alexsohn/feat/add-console-sdk-invite-constants-and-options
to
master
January 8, 2026 21:21
alexsohn1126
deleted the
alexsohn/feat/add-outbox-generation-for-Identity
branch
January 9, 2026 15:57
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, cascade DELETE would not work if a model had a hybrid cloud foreign key (HCFK) on our Identity model.
This PR aims to allow the Identity model to be used as a HCFK.
This will allow the Console SDK GitHub invite model (pr: getsentry#19052) to be deleted if the identity is deleted.