-
Notifications
You must be signed in to change notification settings - Fork 4.8k
test: Upgrade CI postgresql to v18 #121448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 250 commits
9ee42cc
a7ba13b
1ff5ad7
a7f194e
e34a1ca
8027c30
de56b44
ceb7326
cdf7643
2b1425b
2a1f45d
3acdce1
d9e24ba
8bbbea5
f6ef26e
e88a731
53364d8
679a2b0
987c4f7
925d473
58f5325
082621a
a326912
6337bb1
ff990c2
41f5f1e
ce419a6
15ac74f
42c7f50
1707e94
5964bf4
664eb65
2e8b8a4
885f315
1bffa95
28ec841
7da733f
43f5057
519480f
4d88cf9
5f9d51a
a5ee658
43be9b9
1030e8e
904f302
1c6abbd
2364eab
16059c3
752f22f
c297c37
d7577a3
5c9b13b
92a99fd
804b1cd
3381e8a
d247b30
b4b804a
e8ca8ea
1bca28d
aac321c
b0875b3
17c148a
31c5f9e
41083be
1d97dde
60a8f39
2bf1ab5
d710dae
a16e581
42cd9fd
d253f56
5ebb90a
c84aea9
6b5e16b
6300a6e
bd56836
03592d7
5196dc2
8e489ab
7c95edf
1ac27aa
11757ce
e37b353
2f1d6e4
8d2df73
f90e8e7
621d013
a0c714c
d0b5502
7766af7
c8d95ef
8be2031
d744696
b1298e3
02b849c
7181781
b33bfba
a762a05
55bd07a
245bafa
5337a1d
67eac81
b763a6a
721125e
ac674b4
d22aaa6
e200ff8
eb035f7
32aae3b
08a3f6c
4f9af4d
fd2e882
2fee55e
692ba78
fc6c895
e18d5f5
a85a992
89bff72
997c6e5
7485b71
e57a3da
9693350
c6b8e21
44f7a5c
8b8bf26
0f4bb9b
2b6583c
e2878a4
ae798af
66816ed
6c9ea0f
ea9b08d
16e8152
c5b7cb0
ebc9256
d06fa95
8566398
80f70da
f2e20bc
e9d456c
6a0fd41
3840338
22a78fa
fcc3c8d
63c3ea4
b941cfe
91e5796
c9df694
f37cc2f
d2e2a5b
1294c58
8c515ab
b4ea0e8
11c4dc9
8cbb88a
f6d3714
d7851b1
e88441a
6fb8153
f216057
14af38b
6eaf847
223b44f
8d051e7
ecbcae5
6a554f7
32f2a68
cdf32b0
41b0ecd
3996b3a
bf48f7f
8bfed4b
82699f2
6ae30ac
355765c
ebb8272
0a168b6
dad6813
6196806
0c6c3f2
cba6273
bb49acd
737529c
2df45ed
ba1de17
957212f
69ad52b
5dce42e
3d78596
21f99ff
1a9cfca
6ada864
5e9dadd
b91bd75
14ff6b3
b26f322
5796fd0
22ed73f
7dfe4d6
eca9afb
85b73a0
7c47b5c
b218752
0c52d9c
8cea7a5
785c33a
be3d256
8dca03e
a1a5551
ab4fdfb
9d2a3c6
396d649
92fdcd9
13c61f0
dd1b245
5a1ecf1
33d5993
18a56b6
04aac44
2692bfa
c1d4fec
248567a
1b9ca0e
e023d45
ea852bc
4fd0af9
62a6fac
ae5c0b9
64a3577
dd7e143
de1c517
ea465ad
435f96b
c039725
65dbdce
14a86de
3019fab
241d98e
69f6f13
5517200
2755b77
9ed59f1
4333038
0473b75
e5a4994
906db99
3c0c847
3addd83
5d1d4d2
7aca99c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -250,7 +250,7 @@ jobs: | |
| docker run -d --name postgres-postgres-1 \ | ||
| --network devservices --label orchestrator=devservices \ | ||
| -p 127.0.0.1:5432:5432 \ | ||
| -v postgres-data:/var/lib/postgresql/data \ | ||
| -v postgres-data:/var/lib/postgresql \ | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bug: The PostgreSQL volume is mounted at Suggested FixRevert the Docker volume mount path in the Prompt for AI AgentAlso affects:
sentry[bot] marked this conversation as resolved.
sentry[bot] marked this conversation as resolved.
sentry[bot] marked this conversation as resolved.
sentry[bot] marked this conversation as resolved.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bug: The "Reconnect postgres" CI step hardcodes the Docker volume name as Suggested FixInstead of hardcoding the volume name Prompt for AI Agent
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bug: The PostgreSQL volume mount path in Suggested FixVerify that the Prompt for AI Agent
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bug: The "Reconnect postgres" step mounts the volume at Suggested FixVerify that the Prompt for AI Agent
sentry[bot] marked this conversation as resolved.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bug: The hardcoded volume mount Suggested FixVerify that the Prompt for AI Agent
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bug: The PostgreSQL volume mount path was changed to Suggested FixVerify that the external repository branch ( Prompt for AI Agent
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bug: The workflow hardcodes the PostgreSQL volume mount path Suggested FixInstead of hardcoding the volume mount path, inspect the original container (started by Prompt for AI Agent
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bug: A potential mismatch exists between the PostgreSQL volume mount path in the initial container setup ( Suggested FixVerify that the configuration in the Prompt for AI AgentAlso affects:
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bug: The "Reconnect postgres" CI step hardcodes the volume name Suggested FixInstead of hardcoding Prompt for AI Agent
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bug: The CI workflow reconnects to a PostgreSQL container with a new volume mount path. If the initial container from Suggested FixVerify that the configuration in the Prompt for AI AgentAlso affects:
|
||
| -v /tmp/pg-sock:/var/run/postgresql \ | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bug: The CI workflow's PostgreSQL volume mount path is updated for v18, but it doesn't validate the actual image version, risking startup failure or silent data reset with older images. Suggested FixEnforce the PostgreSQL version dependency. Either explicitly use a specific v18+ image tag instead of dynamically inspecting the running container, or add a step to verify the PostgreSQL version from the image before re-running the container with the new volume path. This ensures the volume mount path is compatible with the image being used. Prompt for AI AgentAlso affects:
|
||
| -e POSTGRES_HOST_AUTH_METHOD=trust -e POSTGRES_DB=sentry \ | ||
| "$PG_IMAGE" postgres \ | ||
|
sentry[bot] marked this conversation as resolved.
Comment on lines
250
to
256
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bug: The CI step for restarting PostgreSQL uses a volume path only valid for PostgreSQL 18+, creating a fragile dependency on an unverified external image version. Suggested FixAdd a verification step to the CI workflow to inspect the Prompt for AI AgentAlso affects:
Comment on lines
250
to
256
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bug: The script recreates the Postgres container without preserving its original environment variables. If the initial Suggested FixWhen recreating the container, inspect the original container to capture its environment variables (especially Prompt for AI Agent
Comment on lines
250
to
256
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bug: The PostgreSQL container restart in the CI workflow doesn't preserve the Suggested FixTo ensure the restarted container can find the database, preserve the Prompt for AI Agent
Comment on lines
250
to
256
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bug: The Postgres container is recreated without the Suggested FixExplicitly pass the Prompt for AI Agent |
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -38,7 +38,7 @@ x-sentry-service-config: | |
| description: Shared instance of postgres used by sentry services | ||
| remote: | ||
| repo_name: sentry-shared-postgres | ||
| branch: main | ||
| branch: chore/upgrade-postgres-to-v18 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bug: The Suggested FixAfter the changes in the Prompt for AI AgentDid we get this right? 👍 / 👎 to inform future reviews.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Temporary feature branch dependency pinHigh Severity
Reviewed by Cursor Bugbot for commit e323490. Configure here.
sentry[bot] marked this conversation as resolved.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bug: The Suggested FixBefore merging this pull request, the Prompt for AI Agent
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bug: The Suggested FixOnce the changes in the Prompt for AI Agent
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bug: The Suggested FixThe Prompt for AI Agent |
||
| repo_link: https://github.com/getsentry/sentry-shared-postgres.git | ||
| redis: | ||
| description: Shared instance of redis used by sentry services | ||
|
|
||


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Several CI jobs using
devservices upmay fail as they lack the explicit volume mount fix for PostgreSQL v18 that is present in thebackend-testjob.Severity: HIGH
Suggested Fix
Ensure the configuration in the external
sentry-shared-postgresrepository on thechore/upgrade-postgres-to-v18branch correctly handles the new volume mount path for PostgreSQL v18. Alternatively, apply the explicit volume recreation step from thebackend-testjob to all other CI jobs that depend on the postgres service to ensure consistent behavior.Prompt for AI Agent
Also affects:
devservices/config.yml:41