fix(autofix): Gracefully handle ResourceNotFound for missing branches/repos - #121602
Draft
sentry[bot] wants to merge 1 commit into
Draft
fix(autofix): Gracefully handle ResourceNotFound for missing branches/repos#121602sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Contributor
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses noisy Sentry errors (
ResourceNotFound) occurring in autofix agent functions when attempting to fetch information for GitHub repositories or branches that no longer exist.Previously,
_build_base_shas_metadataand_resolve_default_branchinsrc/sentry/seer/autofix/autofix_agent.pyused a genericexcept Exception:block. This caughtscm.errors.ResourceNotFound(which is raised when GitHub returns a 404 for a missing resource) and logged it as an error, creating unnecessary Sentry issues.This fix introduces a specific
except ResourceNotFound:handler before the generic exception. When aResourceNotFounderror occurs, it is now caught and logged at aninfolevel instead of anexceptionlevel. This allows autofix to gracefully handle cases where a linked repository or branch has been deleted or renamed, reducing Sentry noise while still providing visibility into these events.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes SENTRY-5RA5
Comment
@sentry <feedback>on this PR to have Autofix iterate on the changes.