feat(aci): Rename evaluate_impl to evaluate - #123022
Draft
RudraPatel2003 wants to merge 1 commit into
Draft
Conversation
github-actions
Bot
added
the
Scope: Backend
RudraPatel2003
force-pushed
the
rudra-detector-refactor-3
branch
from
August 28, 2026 17:26
614888d to
b412c35
Compare
RudraPatel2003
force-pushed
the
rudra-detector-refactor-3
branch
from
August 28, 2026 17:39
b412c35 to
464743d
Compare
RudraPatel2003
force-pushed
the
rudra-detector-refactor-3
branch
from
August 28, 2026 17:41
464743d to
3aa79f1
Compare
RudraPatel2003
changed the title
RudraPatel2003
force-pushed
the
rudra-detector-refactor-3
branch
from
August 31, 2026 22:46
3aa79f1 to
b3e2a32
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the "public" non-workflow engine function that consumers must implement so it is public. The _evaluate function that actually gets called is internal to the workflow engine.
But it seems wrong to me that a "private" method (_evaluate) is calling the public one (evaluate)
I may evaluate naming it better in the future, but not in this PR