ref(features): Extract registered batch handler evaluation - #123179
Open
cvxluo wants to merge 1 commit into
Open
ref(features): Extract registered batch handler evaluation#123179cvxluo wants to merge 1 commit into
cvxluo wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
Scope: Backend
cvxluo
force-pushed
the
cvxluo/extract-registered-batch-handler-evaluation
branch
from
August 31, 2026 18:21
08189d9 to
2f35863
Compare
cvxluo
marked this pull request as ready for review
August 31, 2026 18:54
markstory
approved these changes
Aug 31, 2026
markstory
reviewed
Aug 31, 2026
| actor: User | RpcUser | AnonymousUser | None, | ||
| *, | ||
| remaining: set[Project], | ||
| result: dict[Project, bool | None], |
Member
There was a problem hiding this comment.
Should this method return the mutated dict as well? Relying entirely on parameter mutation feels like a more confusing design than returnning values would.
kenzoengineer
approved these changes
Aug 31, 2026
kenzoengineer
left a comment
kenzoengineer
left a comment
Member
There was a problem hiding this comment.
mainly jsut moving code around
Return project decisions and evaluation status from a shared helper. Preserve has_for_batch defaults and partial results on handler errors. Widen actor annotations to match the existing public APIs. Co-authored-by: Claude <noreply@anthropic.com>
cvxluo
force-pushed
the
cvxluo/extract-registered-batch-handler-evaluation
branch
from
August 31, 2026 23:25
2f35863 to
0216a44
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the existing project handler loop into a shared helper. This helps us reuse the logic in
batch_hasin a followup. Also widen actor annotations to match existing usage