Skip to content

ref(ui): Drop unused optional args in gsApp checkout and subscription views - #123237

Open
JonasBa wants to merge 1 commit into
getsentry:masterfrom
JonasBa:jonas/unused-args/gsapp-views
Open

ref(ui): Drop unused optional args in gsApp checkout and subscription views#123237
JonasBa wants to merge 1 commit into
getsentry:masterfrom
JonasBa:jonas/unused-args/gsapp-views

Conversation

@JonasBa

@JonasBa JonasBa commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Split out of #122373 and #122624 so this folder can be reviewed on its own (~143 LOC).

Summary

  • Remove unused optional arguments and fields under static/gsApp/views.
  • Same approach as the original PRs: drop args/fields nothing passes, keep public hook/component options, inline previous defaults.

Files

  • static/gsApp/views/amCheckout/components/cart.tsx
  • static/gsApp/views/amCheckout/steps/productSelect.tsx
  • static/gsApp/views/amCheckout/utils.tsx
  • static/gsApp/views/seerAutomation/onboarding/onboardingLegacy.tsx
  • static/gsApp/views/spendAllocations/index.tsx
  • static/gsApp/views/subscriptionPage/reservedUsageChart.tsx
  • static/gsApp/views/subscriptionPage/usageOverview/components/cta.tsx

Test plan

  • CI typecheck / frontend tests for this slice.
  • Spot-check call sites in static/gsApp/views.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant