feat(explore): show start + finish timestamp in more legible utc - #123238
Open
adrianviquez wants to merge 1 commit into
Open
feat(explore): show start + finish timestamp in more legible utc#123238adrianviquez wants to merge 1 commit into
adrianviquez wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
Scope: Frontend
ryan953
reviewed
Aug 31, 2026
| if (!Number.isFinite(seconds)) { | ||
| return fallback; | ||
| } | ||
| return <DateTime utc year seconds milliseconds date={seconds * 1000} />; |
Member
There was a problem hiding this comment.
might also be helpful to users to wrap this with a tooltip & https://sentry.sentry.io/scraps/core/relativetime/ inside it
ryan953
reviewed
Aug 31, 2026
| import type {TraceTree} from 'sentry/views/performance/newTraceDetails/traceModels/traceTree'; | ||
| import {makeTracesPathname} from 'sentry/views/traces/pathnames'; | ||
|
|
||
| export function renderPreciseTimestamp( |
Member
There was a problem hiding this comment.
can this go into static/app/utils/date or something similar? doesn't seem like it's doing anything that's perf or trace or eap specific. someone could find and re-use it in the future.
ryan953
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making trace attributes like
precise.start_tsandprecise.finish_tsshow up as readable UTC dates instead of raw Unix timestamps for readability, as per #111412. Added tests to confirm the timestamps render correctly and gracefully fall back to the raw value if it isn't a valid number.After
Closes EXP-848