feat(seer): Redesign IconSeer loading animation for ThinkingBlock - #123256
Draft
natemoo-re wants to merge 2 commits into
Draft
feat(seer): Redesign IconSeer loading animation for ThinkingBlock#123256natemoo-re wants to merge 2 commits into
natemoo-re wants to merge 2 commits into
Conversation
Rename IconSeer's animation prop values from 'loading' | 'waiting' to 'idle' | 'loading'. 'idle' keeps the old orbiting-pupil look (previously named 'loading'). 'loading' is a new design: the pupil continuously slides across the eye and wraps around, squashing flat at the wrap point to disguise the reset, giving a rolling rather than oscillating motion. ThinkingBlock now uses the new 'loading' animation while active; all other former 'waiting' callers (checkout upsell, AI setup consent, Seer Explorer empty state/button, investigations cell) move to 'idle' to preserve their existing look.
Contributor
Story previewsPreview the stories changed in this PR on the Vercel deployment:
Preview deployment: https://sentry-m1dm33hlf.sentry.dev |
github-actions
Bot
added
the
Scope: Frontend
The 'loading' rolling animation only translated the pupil circle, leaving the eyelid outline static -- visually wrong compared to the reference design, where the whole eye rolls. Split the icon's single compound path into a static 'body' path (outer triangle, lower band, top notch) and a separate 'eye' path (the eyelid outline around the pupil). The eye path and pupil circle are now grouped together so the rolling transform animates the whole eye as one unit, making the eye itself appear to spin within the static body.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IconSeer'sanimationprop values change from'loading' | 'waiting'to'idle' | 'loading':'idle'keeps the old orbiting-pupil look (previously named'loading').'loading'is a new design: the pupil continuously slides across the eye and wrapsaround, squashing flat at the wrap point to disguise the reset, giving a rolling
motion rather than an oscillation.
ThinkingBlocknow uses the new'loading'animation while active. All other former'waiting'callers (checkout AI upsell, AI setup consent, Seer Explorer emptystate/button, investigations cell) move to
'idle'to preserve their existing look —only
ThinkingBlockgets the new design in this PR.