Skip to content

ref(scraps): Extract leaf components and Prose - #127628

Merged
natemoo-re merged 2 commits into
masterfrom
nm/scraps/extract-leaves
Oct 19, 2026
Merged

natemoo-re merged 2 commits into
masterfrom
nm/scraps/extract-leaves

Conversation

@natemoo-re

@natemoo-re natemoo-re commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

Moves Image, DescriptionList, Prose, Radio, StatusIndicator, and Hotkey into @sentry/scraps, including their package tests.

Prose now uses the packaged inline-code styles directly, allowing the Text fallback to be removed. Package tests use a shared-helper alias so parent-relative imports remain lint errors.

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 15, 2026
@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

@linear-code

linear-code Bot commented Oct 15, 2026

Copy link
Copy Markdown

DE-1729

@natemoo-re
natemoo-re added this pull request to stack #127534 October 15, 2026 20:14
@natemoo-re
natemoo-re marked this pull request as ready for review October 15, 2026 20:48
@natemoo-re
natemoo-re requested review from a team as code owners October 15, 2026 20:48
@natemoo-re

Copy link
Copy Markdown
Member Author

bugbot run

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 9ee1ecb. Configure here.

@sentry

sentry Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Sentry Snapshot Testing

Name Added Removed Changed Renamed Unchanged Skipped Status
sentry-frontend
sentry-frontend
0 0 0 0 630 0 ✅ Unchanged

⚙️ sentry-frontend Snapshot Settings

Comment thread static/packages/scraps/src/statusIndicator/statusIndicator.tsx
Comment thread static/packages/scraps/src/text/text.spec.tsx
Comment thread static/packages/scraps/rslib.config.mjs
Comment thread oxlint.config.ts
Comment thread rsbuild.config.ts
@natemoo-re
natemoo-re force-pushed the nm/scraps/extract-leaves branch from e5434db to 0d786df Compare October 16, 2026 20:35
natemoo-re added a commit that referenced this pull request Oct 19, 2026
…7845)

Checkbox now renders its hover and pressed feedback with local CSS,
removing its dependency on the deprecated `InteractionStateLayer`. The
layer moves from core into application components, and its remaining
consumers import it there.

This keeps the deprecated component out of the Scraps extraction in
#127628. Both PRs use #127423 as their base and can be reviewed
independently.
natemoo-re added a commit that referenced this pull request Oct 19, 2026
…7845)

Checkbox now renders its hover and pressed feedback with local CSS,
removing its dependency on the deprecated `InteractionStateLayer`. The
layer moves from core into application components, and its remaining
consumers import it there.

This keeps the deprecated component out of the Scraps extraction in
#127628. Both PRs use #127423 as their base and can be reviewed
independently.
natemoo-re added a commit that referenced this pull request Oct 19, 2026
…7845)

Checkbox now renders its hover and pressed feedback with local CSS,
removing its dependency on the deprecated `InteractionStateLayer`. The
layer moves from core into application components, and its remaining
consumers import it there.

This keeps the deprecated component out of the Scraps extraction in
#127628. Both PRs use #127423 as their base and can be reviewed
independently.
Base automatically changed from nm/scraps/link to master October 19, 2026 16:29
@natemoo-re
natemoo-re force-pushed the nm/scraps/extract-leaves branch from 0d786df to b1eda19 Compare October 19, 2026 16:36
@natemoo-re
natemoo-re merged commit 0e1d9c1 into master Oct 19, 2026
91 checks passed
@natemoo-re
natemoo-re deleted the nm/scraps/extract-leaves branch October 19, 2026 16:47

This branch was successfully deployed

1 active deployment
Preview — b1eda198 Deployed Oct 19, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants