Repository navigation
Conversation
…n is gone SentryAppPermission, SentryInternalAppTokenPermission and SentryAppAuthorizationsPermission asserted that the owner or installation organization exists. SentryApp.owner_id and SentryAppInstallation.organization_id are cross-silo foreign keys, so the organization can be deleted before its tombstone removes the app, and a request in that window failed with a 500. Log and return False, as SentryAppStatsPermission and SentryAppWebhookRequestsPermission already do. Refs getsentry#127961
github-actions
Bot
added
the
Scope: Backend
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three Sentry App permission classes assert that the app's organization exists, but it can be gone before its tombstone cascades, so the request 500s. They now log and deny, as
SentryAppStatsPermissionalready does.New tests fail on master and pass here;
GET /sentry-apps/{slug}/returns 403, not 500. Covers item 4 of the issue only.Refs #127961
Written with AI assistance (Claude Code), reviewed and tested by me.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.