Skip to content

Commit 05e0af9

Browse files
committed
fix: changed the social auth callback redirect to put token back into the query string and updated env example
1 parent ac2a809 commit 05e0af9

2 files changed

Lines changed: 3 additions & 4 deletions

File tree

‎.env.example‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,3 +36,5 @@ EMAIL_FROM=onboarding@resend.dev
3636

3737
# ── Frontend ──────────────────────────────────────────────────────────────────
3838
FRONTEND_URL=http://localhost:5173
39+
40+
PUBLIC_API_URL=https://api.ub.bitbros.in

‎apps/public-api/src/controllers/userAuth.controller.js‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -638,7 +638,6 @@ module.exports.startSocialAuth = async (req, res) => {
638638
/**
639639
* Handles the OAuth provider callback. Validates state, exchanges code, resolves/creates user,
640640
* issues auth tokens, and redirects to the frontend callback URL.
641-
* Access token is in the URL fragment (#token=...) to avoid server log exposure.
642641
* @route GET /api/userAuth/social/:provider/callback
643642
*/
644643
module.exports.handleSocialAuthCallback = async (req, res) => {
@@ -722,15 +721,13 @@ module.exports.handleSocialAuthCallback = async (req, res) => {
722721

723722
const callbackBaseUrl = parsedState.callbackUrl || getFrontendCallbackBaseUrl(project);
724723
const callbackUrl = new URL(callbackBaseUrl);
724+
callbackUrl.searchParams.set('token', issuedTokens.accessToken);
725725
callbackUrl.searchParams.set('rtCode', rtCode);
726726
callbackUrl.searchParams.set('provider', provider);
727727
callbackUrl.searchParams.set('userId', String(user._id));
728728
callbackUrl.searchParams.set('projectId', String(project._id));
729729
callbackUrl.searchParams.set('isNewUser', String(isNewUser));
730730
callbackUrl.searchParams.set('linkedByEmail', String(linkedByEmail));
731-
const fragmentParams = new URLSearchParams();
732-
fragmentParams.set('token', issuedTokens.accessToken);
733-
callbackUrl.hash = fragmentParams.toString();
734731

735732
return res.redirect(callbackUrl.toString());
736733
} catch (err) {

0 commit comments

Comments
 (0)