Skip to content

Commit 731ff15

Browse files
committed
fix: standard api res parsing
1 parent 08f90b6 commit 731ff15

1 file changed

Lines changed: 11 additions & 3 deletions

File tree

‎packages/common/src/middleware/standardizeApiResponse.js‎

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,10 @@ const pickMessage = (value) => {
2323

2424
if (value && typeof value === 'object') {
2525
if (typeof value.message === 'string' && value.message.trim()) return value.message;
26+
if (typeof value.error === 'string' && value.error.trim()) return value.error;
2627
if (Array.isArray(value.errors) && value.errors[0]?.message) return value.errors[0].message;
2728
if (Array.isArray(value.issues) && value.issues[0]?.message) return value.issues[0].message;
29+
if (Array.isArray(value.error) && value.error[0]?.message) return value.error[0].message;
2830
}
2931

3032
return null;
@@ -40,9 +42,15 @@ const toErrorMessage = (raw) => {
4042
}
4143

4244
const serialized = safeStringify(raw);
43-
return serialized === '{}' || serialized === '[]' || serialized === 'null' || serialized === '""'
44-
? 'Unknown error'
45-
: serialized;
45+
// Only mask as 'Unknown error' if the serialized body is trivial (empty)
46+
const isTrivial = serialized === '{}' || serialized === '[]' || serialized === 'null' || serialized === '""';
47+
48+
if (isTrivial) {
49+
return 'Unknown error';
50+
}
51+
52+
// Otherwise, return the stringified body so we don't mask potentially useful data
53+
return serialized;
4654
};
4755

4856
module.exports = (req, res, next) => {

0 commit comments

Comments
 (0)