feat: show startup progress in the chat feed - #234
Open
wowi42 wants to merge 2 commits into
Open
Conversation
Launch dropped the user into an empty feed with no indication of what was loaded. The startup sequence now reports itself in the chat UI, where it stays as scrollable history: - Banner: gradient ASCII logo + version (compact text fallback on narrow terminals). Model, context window, prompt, branch and cwd are not repeated here; they already live in the statusline. - Startup log: global/local config files, prompts and themes (with project-local counts), context files (AGENTS.md/ARCHITECTURE.md), build features, session restore, subagents, model pricing, tools & permissions — with per-step timings. - MCP servers connect after the TUI opens and report live, one line per server, with tool counts and connect times; the agent-ready line totals servers and tools. - Subagent/advisor/sandbox degradation warnings (previously only in tracing logs) surface as red '!' lines. - New show_boot_screen config key (default true) to silence the log. - Fix u16 underflow panic in draw_bottom on tiny terminals by reusing the saturating input_top for input and cursor rows.
Owner
|
make sense, but:
|
Resolve conflicts with the startup timing instrumentation and the live model-info fetch, and address review feedback and CI failures: - Drop the ASCII logo/gradient banner (breaks the IBM design ethos); the banner is a plain `zerostack vX.Y.Z` line again. - Gate the startup info lines behind a new opt-in `show_additional_info_startup` config key (default false); MCP loading lines stay visible by default. - Clippy: box PrebuildEvent::Done (large_enum_variant), allow cfg-gated pushes in active_features (vec_init_then_push / unused_mut), fix irrefutable let / never_loop in the no-mcp resolve_prebuild, gate MCP-only helpers for no-default builds.
Contributor
Author
|
Thanks for the review — both points addressed in the merge commit:
Also fixed the CI failures:
All four flavors now pass locally: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Launching zerostack dropped the user into an empty feed — no logo, no indication of what was loaded, and MCP servers connecting silently in the background. This PR makes the startup sequence report itself directly in the chat UI, where it stays as scrollable history (no separate splash screen, single alt-screen entry).
Changes
zerostack vX.Y.Zline — no logo, in keeping with the IBM-style design. Model/context/prompt/branch/cwd are not repeated — they already live in the statusline.src/ui/boot.rs, pure + unit-tested), opt-in viashow_additional_info_startup(defaultfalse): global/local config, prompts/themes with project-local counts, context files, compile-time feature list, session restore, subagents, model info, tools & permissions — with per-step timings.connect_all_with_progress, one line per server with tool count and connect time;McpClientManagercachestool_countsand the agent-ready line totals them.tracinglogs — they now show as red!lines.draw_bottompanicked with u16 underflow ("attempt to subtract with overflow") on tiny/0-height terminals; input and cursor rows now reuse the already-saturatinginput_top.show_additional_info_startupkey (defaultfalse) to opt into the startup info lines; MCP loading lines always show. Documented indocs/CONFIG.md.-p,--loop,--acp) are untouched — stdout stays clean.Verification
cargo test: 706 passed (incl. new tests for boot state, banner, feed color override, durations, features list)cargo fmt,cargo install --path . --debug