Add phpcs + fix code - #446
Open
pajon wants to merge 37 commits into
Open
Conversation
Collaborator
Author
|
@thewunder Sorry for tagging, but i need finish and merge this PR. I want continue with next changes. |
pajon
force-pushed
the
phpcs
branch
2 times, most recently
from
March 20, 2020 19:46
4689880 to
0234ee3
Compare
Collaborator
Author
|
I also added type hints to code. Sorry for doing multiple changes in one MR, but I understand you don't have much time to merge multiple MR. If you want i can split these changes into multiple MR. |
Collaborator
Author
|
@thewunder Thank you |
Fix automatic fixable phpcs issues update phpcs config Fix phpcs issues manually update phpcs config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi guys,
i added phpcs to improve code quality. Rules were created from Doctrine + some rules were disabled.
Feel free to discus about it.
Thank you
P.S.
This PR contains #445 fix.