testkit: OUTPUT_PATTERN guard; prebuilt CLI for spec-kit CI (#7)

<!-- CURSOR_AGENT_PR_BODY_BEGIN -->
## Summary

- **CliBridge**: `runGitCmd` uses `extractRequired(json, OUTPUT_PATTERN,
"output")` only, consistent with `getCurrentSha` / `getBranches` (no
redundant pre-check; per CodeRabbit review).
- **CI (`spec-kit-conformance`)**: After `go build
./cmd/git-testkit-cli`, Python and Maven steps set
`GIT_TESTKIT_CLI=./git-testkit-cli` so wrappers invoke the prebuilt
binary instead of `go run` on every subprocess.
- **Docs**: `testkit/README.md` describes the Go regression root as the
directory containing `go.mod` (avoids implying a fixed path like
`/workspace`). `testkit/ROADMAP.md` spells out that the CLI lives under
`cmd/git-testkit-cli`, not a separate `testkit/cli` tree.

## Notes

On current `main`, `invoke()` already uses `OK_PATTERN` for the `ok`
field; the `wrapper-cross-platform` job already builds the CLI and sets
`GIT_TESTKIT_CLI`. There is no `GitTestKitCLI` alias in `cli.py`
anymore.

## Testing

- `go test -short ./...` (Java/Maven not available in this environment).
<!-- CURSOR_AGENT_PR_BODY_END -->

<div><a
href="https://cursor.com/agents/bc-0292fb44-cedd-46e2-ba47-4395056bc137"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-web-light.png"><img
alt="Open in Web" width="114" height="28"
src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a>&nbsp;<a
href="https://cursor.com/background-agent?bcId=bc-0292fb44-cedd-46e2-ba47-4395056bc137"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img
alt="Open in Cursor" width="131" height="28"
src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a>&nbsp;</div>



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Documentation**
  * Clarified command execution instructions for repository setup.
  * Updated project roadmap specifications.

* **Chores**
  * Enhanced continuous integration workflow configuration.

* **Refactor**
  * Improved validation logic for better reliability.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Ben Schellenberger <bschellenberger2600@users.noreply.github.com>

Author: bschellenberger2600

.github/workflows/ci.yml

@@ -45,21 +45,29 @@ jobs:
           cache: maven
 
       - name: Run Python spec conformance smoke tests
+        env:
+          GIT_TESTKIT_CLI: ./git-testkit-cli
         run: |
           cd testkit/python
           python -m pip install -e ".[dev]"
           python -m pytest tests/ -v
       - name: Run Python sample smoke implementations
+        env:
+          GIT_TESTKIT_CLI: ./git-testkit-cli
         run: |
           cd testkit/python
           python -m samples.smoke_repo_flow
           python -m samples.smoke_snapshot_flow
 
       - name: Run Java spec conformance smoke tests
+        env:
+          GIT_TESTKIT_CLI: ./git-testkit-cli
         run: |
           cd testkit/java
           mvn test
       - name: Run Java sample smoke implementations
+        env:
+          GIT_TESTKIT_CLI: ./git-testkit-cli
         run: |
           cd testkit/java
           mvn -Dtest=SampleRepoFlowSmoke,SampleSnapshotFlowSmoke test

testkit/README.md

@@ -24,7 +24,7 @@ Use existing smoke tests as the executable conformance path:
 
 - Python: `cd testkit/python && python3 -m pytest tests/ -v`
 - Java: `cd testkit/java && mvn test`
-- Go regression: from repository root, run `go test ./...`
+- Go regression: from the repository root (the directory containing `go.mod`), run `go test ./...`
 
 ### CI/CD wiring
 

testkit/ROADMAP.md

@@ -17,7 +17,7 @@ Deliverables:
 
 1. Keep existing Go `testing.T` APIs for backward compatibility.
 2. Add reusable error-returning Go APIs that do not depend on `testing.T`.
-3. Add CLI binary (`cmd/git-testkit-cli`) with JSON request/response protocol.
+3. Add CLI binary at `cmd/git-testkit-cli` (canonical Go entrypoint; not a separate `testkit/cli` tree) with JSON request/response protocol.
 4. Add Python and Java thin wrappers that shell out to the CLI.
 5. Add smoke tests proving fixture -> scenario-like flow -> snapshot round-trip.
 6. Add spec-kit artifact set under `.specify/`:

testkit/java/src/main/java/io/gitfire/testkit/CliBridge.java

@@ -254,9 +254,6 @@ public String runGitCmd(String repoPath, String... args) {
     }
     payload.append("]}");
     String json = invoke(payload.toString());
-    if (!json.contains("\"output\"")) {
-      throw new IllegalStateException("missing output in bridge response: " + json);
-    }
     return extractRequired(json, OUTPUT_PATTERN, "output");
   }