coverity: skip building with Rust, for now - #6291
Merged
Merged
Conversation
CI runs in GitHub Actions runners are ill-equipped to build with Rust, as the Windows/GCC-compatible toolchain isn't set up. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Coverity reported that the new `mingw_rename()` function may overrun the `FileName` buffer if using a long path. The reason is that I forgot to adjust it for long path support, and while looking at this, I realized that I also had forgotten to adjust `mingw_strbuf_realpath()` and `is_path_owned_by_current_sid()`, too. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
marked this pull request as ready for review
June 23, 2026 16:14
derrickstolee
approved these changes
Jun 23, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that Coverity is finally back up. So we need to suppress the Rust parts to allow our corresponding workflow to succeed.